Closed Bug 1513561 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 14479 - Align resource timing buffer full processing to spec PR 168 (take 3)

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14479 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14479
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:
>  Align resource timing buffer full processing to spec PR 168 (take 3)
>  
>  This change implements the processing model from PR 168[1], when
>  it comes to setResourceTimingBufferSize(), clearResourceTimings()
>  and the firing of the resourcetimingbufferfull event.
>  
>  This is a reland of [2] which is a reland of [3] (but with nicer tests).
>  
>  [1] https://github.com/w3c/resource-timing/pull/168
>  [2] https://chromium-review.googlesource.com/c/chromium/src/+/1350950
>  [3] https://chromium-review.googlesource.com/c/chromium/src/+/1345269
>  
>  Bug: 908181, 908414
>  Change-Id: I3a6c6e9d6a9aa5b5f907d1e86bec701ff2fa022d
>  Reviewed-on: https://chromium-review.googlesource.com/1373819
>  WPT-Export-Revision: 4cc92a2173faabe29a490600a069f73ab7965d42
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 12 tests and 15 subtests
OK     : 3
PASS   : 3
FAIL   : 3
TIMEOUT: 13
ERROR  : 4
NOTRUN : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/service-workers/service-worker/performance-timeline.https.html: TIMEOUT
    Resource Timing: TIMEOUT
    Test Performance Timeline API in Service Worker: TIMEOUT
    empty service worker fetch event included in performance timings: NOTRUN

New tests that have failures or other problems:
/resource-timing/buffer-full-add-after-full-event.html: TIMEOUT
    Test that entry was added to the buffer after a buffer full event: TIMEOUT
/resource-timing/buffer-full-add-entries-during-callback-that-drop.html: TIMEOUT
    Test that entries synchronously added to the buffer during the callback are dropped: TIMEOUT
/resource-timing/buffer-full-add-entries-during-callback.html: TIMEOUT
    Test that entries synchronously added to the buffer during the callback don't get dropped if the buffer is increased: TIMEOUT
/resource-timing/buffer-full-add-then-clear.html: ERROR
    Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one: FAIL
/resource-timing/buffer-full-inspect-buffer-during-callback.html: ERROR
    Test that entries in the secondary buffer are not exposed during the callback and before they are copied to the primary buffer: TIMEOUT
/resource-timing/buffer-full-set-to-current-buffer.html: TIMEOUT
    Test that entries added and event firing happened in the right sequence: TIMEOUT
/resource-timing/buffer-full-store-and-clear-during-callback.html
    Test that entries overflowing the buffer trigger the buffer full event, can be stored, and find themselves in the primary buffer after it's cleared.: FAIL
/resource-timing/buffer-full-then-increased.html: ERROR
    Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event: FAIL
/resource-timing/buffer-full-when-populate-entries.html: ERROR
    Test that a buffer full event does not bubble and that resourcetimingbufferfull is called only once per overflow: TIMEOUT
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f9e6a2b7a8f
[wpt PR 14479] - Align resource timing buffer full processing to spec PR 168 (take 3), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e4cc4552f5e
[wpt PR 14479] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.