1513565 - Stop using target.form outside of Target class

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

When we are going to merge Target with its retated fronts, it is going to inherit from Front class, which also implement a "form" method. It will collide with existing form attribute of Target.

We are still using Target's form attribute outside of Target class, but we should really stop doing that. Form should be a private of target. We should instead use getFront to instantiate fronts or for the couple of old fashion client, use custom methods on Target to create them out of the form (Target.attach does a bit of that already).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually.

This will help getting rid of another usage of Target.form.
And also helps instantiating only one WebConsole client.
Once WebConsole becomes a front, we can replace all the target.activeTab
to target.getFront("console").

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1513565 - Get rid of all target.form usages.

Depends on D14278

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1513565 - Convert the last manually instantiated fronts to target.getFront.

Depends on D14279

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1513565 - Remove now-unused form argument from Target.

Depends on D14280

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af4a0603c641
Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/69c7978b620c
Get rid of all target.form usages. r=yulia,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/835e98747541
Convert the last manually instantiated fronts to target.getFront. r=yulia
https://hg.mozilla.org/integration/autoland/rev/3d30fc6ff7c4
Remove now-unused form argument from Target. r=yulia

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/af4a0603c641
https://hg.mozilla.org/mozilla-central/rev/69c7978b620c
https://hg.mozilla.org/mozilla-central/rev/835e98747541
https://hg.mozilla.org/mozilla-central/rev/3d30fc6ff7c4