Closed Bug 1513565 Opened 10 months ago Closed 10 months ago

Stop using target.form outside of Target class

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission)

Attachments

(4 files)

When we are going to merge Target with its retated fronts, it is going to inherit from Front class, which also implement a "form" method. It will collide with existing form attribute of Target.

We are still using Target's form attribute outside of Target class, but we should really stop doing that. Form should be a private of target. We should instead use getFront to instantiate fronts or for the couple of old fashion client, use custom methods on Target to create them out of the form (Target.attach does a bit of that already).
This will help getting rid of another usage of Target.form.
And also helps instantiating only one WebConsole client.
Once WebConsole becomes a front, we can replace all the target.activeTab
to target.getFront("console").
Depends on D14278
Assignee: nobody → poirot.alex
Depends on: 1514819
Summary: Stop using target.form outside outside of Target class → Stop using target.form outside of Target class
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af4a0603c641
Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/69c7978b620c
Get rid of all target.form usages. r=yulia,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/835e98747541
Convert the last manually instantiated fronts to target.getFront. r=yulia
https://hg.mozilla.org/integration/autoland/rev/3d30fc6ff7c4
Remove now-unused form argument from Target. r=yulia
Depends on: 1516250
Depends on: 1516408
You need to log in before you can comment on or make changes to this bug.