1513594 - Implement NestedScrollingChild interface in GeckoView

Status: RESOLVED WORKSFORME

(GeckoView :: General, enhancement, P2)

Description

[Eitan Isaacson [:eeejay]]

This is currently done in Android Components[1], and it is used for autohiding the toolbar. Looks like this is a common mobile browser pattern..

It seems like it would be good to control this behavior directly so we could deal with viewport size changes and update GeckoSession's position correctly.

1. https://github.com/mozilla-mobile/android-components/blob/f7264a7afc9c72a5a6dd788671232ccea5ee6e40/components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/NestedGeckoView.kt

Comment 1

[Chris Peterson [:cpeterson]]

James says P2.

Comment 2

[Eitan Isaacson [:eeejay]]

Depending on the outcome of bug 1515774, I'm not sure this is needed anymore.

It puts more 'policy' in GeckoView's control. Not sure if that is a good thing. With the right APIs consumers should be able to control nested scrolling themselves.

I originally proposed this because I thought it would help us have an informed idea of what the GeckoView's offset is in a CoordinatedLayout, but I realize now that that is not the case.

Comment 3

[Eitan Isaacson [:eeejay]]

We may need another API that would tell GeckoView how much of it's vertical space is clipped. That will help with adjusting the bottom-fixed margin, and potential viewport resizing.

Comment 4

[Eitan Isaacson [:eeejay]]

Going to close this since I think this has mostly resolved itself with the APZ changes and the clipping API.