1513597 - Fix/enable ESLint react/forbid-prop-types

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P2)

Description

[Ed Morley [:emorley]]

There are 165 instances that need fixing :-/

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md

Comment 1

[Ed Morley [:emorley]]

Example failure shown by `yarn lint` after removing the rule-disabling from .eslintrc.js:

error: Prop type `object` is forbidden (react/forbid-prop-types) at ui\job-view\pushes\Push.jsx:454:3:
  452 |
  453 | Push.propTypes = {
> 454 |   push: PropTypes.object.isRequired,
      |   ^

Comment 2

[shavindra]

Is this still valid?

Comment 3

[Cameron Dawson [:camd]]

This bug is still valid, yes. I think what we need to do is update these uses of PropTypes.object to define a shape for these props. Are you interested in working on this?

Comment 4

[Bola Buari [:bolah2009]]

Hi, can you assign me to this? I would like to work on it. Thanks.

Comment 5

[Cameron Dawson [:camd]]

Thanks! I appreciate you taking a crack at this. :)

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6308

Comment 7

[Logan Rosen [:Logan]]

The linked PR was merged, and this rule is no longer turned off. Closing as fixed.