Closed
Bug 1513606
Opened 5 years ago
Closed 5 years ago
Deprecate code in Fetch
Categories
(Core :: DOM: File, enhancement)
Core
DOM: File
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
10.94 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9030802 -
Flags: review?(bugs)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9030802 [details] [diff] [review] fetch_deprecated.patch oh, not deprecating, but removing unused code. Please fix the commit message. s/Deprecate/Remove unused/
Attachment #9030802 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c1fe6332049 Remove unused code in Fetch, r=smaug
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c1fe6332049
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 5•5 years ago
|
||
:baku, we potentially want these types back for ServiceWorkerPrivate remoting so that the abstraction can deal in (Internal)Request/(Internal)Response objects rather than propagating the necko channel abstraction further. Is there any reason in principal not to add this code back? (Although obviously we would add it back at the same time with logic that consumes it.)
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Comment 6•5 years ago
|
||
We can have this code back, of course, if needed. I just removed this code because it was not used at all.
Flags: needinfo?(amarchesini)
You need to log in
before you can comment on or make changes to this bug.
Description
•