1513626 - Mismatch in clang-format config between central repo and phabricator clang-format configuration

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

Seen in https://phabricator.services.mozilla.com/D14282#inline-77180

I had:

  nsCOMPtr<nsIRunnable> runnable = NS_NewRunnableFunction(
      "dom::HTMLTrackElement::LoadResource",
      [ self = RefPtr<HTMLTrackElement>(this), uri, secFlags ]() {

        nsCOMPtr<nsIChannel> channel;


local clang-format using the existing mozilla-central/.clang-formant accept this formatting as is.

However, the clang-format used in phabricator will warn on those.

central's .clang-format should be made to match what phabricator wants.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

another example of that https://phabricator.services.mozilla.com/D15426#387898 (oh, irony ;)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

One more example:
https://phabricator.services.mozilla.com/D16388

Andi, do you have an update on that? thanks

Comment 3

[Andi [:andi]]

This is a problem with the bot that doesn't behaves as we might want to, please see this related bug.
I think it's safe to track this bug on GitHub, where we have our release-services repo is located.

Comment 4

[Andi [:andi]]

As the patch has been merged into master and the serve has been redeployed from master, we can close this issue.