1513647 - Fetch doesn't configure MutableBlobStorage to use temporary files

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Andrea Marchesini [:baku]]

Fetch uses MutableBlobStorage always in 'in-memory' configuration.
This happens because we don't set the principalInfo in the InternalResponse object.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fetch_blob.patch

a couple of comments about this patch:

1. we cannot use NS_DISPATCH_SYNC on the necko thread. I changed this to NS_DISPATCH_NORMAL.
2. It's important to use lock when the actor is set.
3. Tests are nice, but they are not actually testing MutableBlobStorage, because it's impossible to see if the blob data has been stored into a temporary file.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

For testing, we could have a [ChromeOnly] thing on the Blob object the test the backend.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9030842 [details] [diff] [review]
fetch_blob.patch

I think I'd like to see that webidl property for testing. Or it could be also some helper method in nsIDOMWindowUtils or so.
But anyhow, some way for tests to check that we use the expected blob backend. Otherwise regressions are quite likely.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: fetch_blob.patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9031805 [details] [diff] [review]
fetch_blob.patch

In the commit message s/use/used/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed660a4a701
MutableBlobStorage should be used in eCouldBeInTemporaryFile mode for fetch(), r=smaug

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2ed660a4a701