Closed Bug 1513654 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14480 - Serialize animation in the right order

Categories

(Core :: CSS Transitions and Animations, enhancement, P4)

Product:
Core
Component:
CSS Transitions and Animations
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14480 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14480
Details from upstream follow.

Xida Chen <xidachen@chromium.org> wrote:
>  Serialize animation in the right order
>  
>  Per spec:
>  https://drafts.csswg.org/css-animations/#animation
>  The name of the animation should be the end of the value list.
>  
>  This CL fixes the problem for both element.style and the
>  window.getComputedStyle. A wpt test is added.
>  
>  Bug: 772852
>  Change-Id: I88b06b57c68013d99c8c4fd4bd39bdfcf9b807fc
>  Reviewed-on: https://chromium-review.googlesource.com/1367935
>  WPT-Export-Revision: ca313440b18d74152c0e06e514db12471a5e85b9
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Component: CSS Parsing and Computation → CSS Transitions and Animations
I expect this is failing because we don't expose 'animation' (a shorthand) on getComputedStyle. Specifically the line that does:

  style2.animation = computedStyle1.animation;

It was only recently resolved we should do this:

  https://github.com/w3c/csswg-drafts/issues/2529

Not sure if we have a bug for fixing that yet.
Ran 1 tests and 5 subtests
OK     : 1
FAIL   : 5

New tests that have failures or other problems:
/css/css-animations/animations-parsing.html
    Test a non-conflicting animation name.: FAIL
    Test an animation name that is the same as a possible animation direction.: FAIL
    Test an animation name that is the same as a possible animation fill-mode.: FAIL
    Test an animation name that is the same as a possible running state.: FAIL
    Test animation name being empty.: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d762f13655
[wpt PR 14480] - Serialize animation in the right order, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6529b88b34a
[wpt PR 14480] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.