1513674 - Twice-reported memory allocations in url-classifier code

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1513672 +++

I ran DMD today on a WR-enabled mac build to chase down bug 1491512 a bit more, and the DMD report told me about some twice-reported blocks. Attached is the full log. There is the entry below in safe browsing code. Full log is attached to bug 1513672.

Twice-reported {
  2 blocks in heap block record 4 of 11
  416 bytes (400 requested / 16 slop)
  Individual block sizes: 208 x 2
  0.00% of the heap (0.00% cumulative)
  5.45% of twice-reported (81.76% cumulative)
  Allocated at {
    #01: (no stack trace recorded due to --stacks=partial)
  }
  Reported at {
    #01: mozilla::dmd::ReportHelper(void const*, bool) (DMD.cpp:425, in libmozglue.dylib)
    #02: nsUrlClassifierPrefixSet::CollectReports(nsIHandleReportCallback*, nsISupports*, bool) (DMD.h:0, in XUL)
    #03: non-virtual thunk to nsUrlClassifierPrefixSet::CollectReports(nsIHandleReportCallback*, nsISupports*, bool) (nsUrlClassifierPrefixSet.cpp:0, in XUL)
    #04: mozilla::detail::RunnableFunction<nsMemoryReporterManager::DispatchReporter(nsIMemoryReporter*, bool, nsIHandleReportCallback*, nsISupports*, bool)::$_0>::Run() (nsMemoryReporterManager.cpp:1850, in XUL)
    #05: nsThread::ProcessNextEvent(bool, bool*) (nsThread.cpp:1144, in XUL)
    #06: NS_ProcessPendingEvents(nsIThread*, unsigned int) (nsThreadUtils.cpp:416, in XUL)
    #07: nsBaseAppShell::NativeEventCallback() (nsBaseAppShell.cpp:88, in XUL)
    #08: nsAppShell::ProcessGeckoEvents(void*) (nsAppShell.mm:465, in XUL)
  }
  Reported again at {
    #01: mozilla::dmd::ReportHelper(void const*, bool) (DMD.cpp:425, in libmozglue.dylib)
    #02: mozilla::safebrowsing::UrlClassifierMallocSizeOf(void const*) (VariableLengthPrefixSet.cpp:424, in XUL)
    #03: mozilla::safebrowsing::VariableLengthPrefixSet::SizeOfIncludingThis(unsigned long (*)(void const*)) const (VariableLengthPrefixSet.cpp:447, in XUL)
    #04: mozilla::safebrowsing::VariableLengthPrefixSet::CollectReports(nsIHandleReportCallback*, nsISupports*, bool) (VariableLengthPrefixSet.cpp:431, in XUL)
    #05: mozilla::detail::RunnableFunction<nsMemoryReporterManager::DispatchReporter(nsIMemoryReporter*, bool, nsIHandleReportCallback*, nsISupports*, bool)::$_0>::Run() (nsMemoryReporterManager.cpp:1850, in XUL)
    #06: nsThread::ProcessNextEvent(bool, bool*) (nsThread.cpp:1144, in XUL)
    #07: NS_ProcessPendingEvents(nsIThread*, unsigned int) (nsThreadUtils.cpp:416, in XUL)
    #08: nsBaseAppShell::NativeEventCallback() (nsBaseAppShell.cpp:88, in XUL)
  }
}

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Whoops, cloned into the wrong component...

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1513674 - Remove nsIMemoryReporter from fixed-length prefix. r?gcp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc28751a49a3
Remove nsIMemoryReporter from fixed-length prefix. r=gcp

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fc28751a49a3