moving to fluent in bug 1498448 broke exporting certificates from the certificate viewer

RESOLVED FIXED in Firefox 65

Status

()

defect
P1
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: keeler, Assigned: Gijs)

Tracking

({regression})

unspecified
Firefox 66
Unspecified
All
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65+ fixed, firefox66+ fixed)

Details

Attachments

(1 attachment)

Bug 1498448 removed the string bundle that certViewer.xul uses to export certificates (the actual use is in pippki.js, which is unfortunately convoluted).

STR: open the certificate viewer (e.g. view page info -> security -> view certificate), go to the details tab, click "export"
OS: Unspecified → All
We should probably add tests for this. :-(
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: in-testsuite?
Priority: -- → P1
Depends on: 1514239
Tracking to make sure we follow up with beta uplift.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ac2c5d30013
bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r=jaws
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bcc96228ac8
Backed out changeset 8ac2c5d30013 as requested by Gijs for causing leaks.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/90a1eb1a99de
bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r=jaws
https://hg.mozilla.org/mozilla-central/rev/90a1eb1a99de
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment on attachment 9031435 [details]
Bug 1513710 - bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498448

User impact if declined: Users can't export certificates

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes (automatically, with a new test that's part of this commit)

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: n/a

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This just re-creates the stringbundle on which this code depended anyway, and ensures it's in the document -- and it adds an automated test to ensure we don't accidentally break this again.

String changes made/needed: None - the strings were still there, but we accidentally removed the stringbundle before removing all uses of it
Attachment #9031435 - Flags: approval-mozilla-beta?
Flags: qe-verify-
Flags: in-testsuite?
Flags: in-testsuite+
Comment on attachment 9031435 [details]
Bug 1513710 - bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r?jaws

[Triage Comment]
Fixes broken certificate exporting and includes a new automated test. Approved for 65.0b5.
Attachment #9031435 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.