1513710 - moving to fluent in bug 1498448 broke exporting certificates from the certificate viewer

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Dana Keeler (she/her) [:keeler]]

Bug 1498448 removed the string bundle that certViewer.xul uses to export certificates (the actual use is in pippki.js, which is unfortunately convoluted).

STR: open the certificate viewer (e.g. view page info -> security -> view certificate), go to the details tab, click "export"

Comment 1

[:Gijs (he/him)]

We should probably add tests for this. :-(

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1513710 - bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r?jaws

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking to make sure we follow up with beta uplift.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ac2c5d30013
bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r=jaws

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bcc96228ac8
Backed out changeset 8ac2c5d30013 as requested by Gijs for causing leaks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a1eb1a99de
bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r=jaws

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/90a1eb1a99de

Comment 8

[:Gijs (he/him)]

Comment on attachment 9031435 [details]
Bug 1513710 - bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498448

User impact if declined: Users can't export certificates

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes (automatically, with a new test that's part of this commit)

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: n/a

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This just re-creates the stringbundle on which this code depended anyway, and ensures it's in the document -- and it adds an automated test to ensure we don't accidentally break this again.

String changes made/needed: None - the strings were still there, but we accidentally removed the stringbundle before removing all uses of it

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9031435 [details]
Bug 1513710 - bring back stringbundle on-demand for certificate export code, and add a test for certificate exports, r?jaws

[Triage Comment]
Fixes broken certificate exporting and includes a new automated test. Approved for 65.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5281e679d232