1513749 - Deduplicate element(s)FromPoint and nodesFromRect.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This will make bug 1513658 trivial.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1513749 - Modernize a bit nsLayoutUtils::GetFrameForPoint / GetFrameForArea. r=mats

Also add an IsElement check in GetElementFromPoint in the APZ code since I think
the element cast is unsound in presence of Shadow DOM.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1513749 - Move NodesFromRectHelper to DocumentOrShadowRoot. r=mats

We'll factor the commont bits out in a bit.

Depends on D14355

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1513749 - Rename and make nodesFromRect infallible. r=mats

This way it has a more WebIDL-like signature, which will be helpful in a second.

Depends on D14356

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1513749 - Deduplicate NodesFromRect and Element(s)FromPoint. r=mats

Depends on D14357

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Hey Mats, I don't know how you feel about these. The point of these changes is to make bug 1513658 trivially implementable without duplicating a bunch of logic. But for that the EnumSet stuff is not needed.

I think I like the end result slightly better, but I don't feel too strongly about it, so if you want me to remove the first change I can do that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/3acd87aa7826
Modernize a bit nsLayoutUtils::GetFrameForPoint / GetFrameForArea. r=mats
https://hg.mozilla.org/mozilla-central/rev/72b9ffb09547
Move NodesFromRectHelper to DocumentOrShadowRoot. r=mats
https://hg.mozilla.org/mozilla-central/rev/4cea8f588b87
Rename and make nodesFromRect infallible. r=mats
https://hg.mozilla.org/mozilla-central/rev/7fde7d6f3628
Deduplicate NodesFromRect and Element(s)FromPoint. r=mats

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3acd87aa7826
https://hg.mozilla.org/mozilla-central/rev/72b9ffb09547
https://hg.mozilla.org/mozilla-central/rev/4cea8f588b87
https://hg.mozilla.org/mozilla-central/rev/7fde7d6f3628