Closed Bug 1513753 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14483 - Reland "Fix SVG-As-Background sizing"

Categories

(Core :: Layout, enhancement, P4)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14483 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14483
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:
>  Reland "Fix SVG-As-Background sizing"
>  
>  This is a reland of aed99d7e12bd036ab3ebb4fe522ce8faf347a32f
>  It was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1373285
>  But the real culprit is a recipe change which is being reverted in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509
>  
>  Original change's description:
>  > Fix SVG-As-Background sizing
>  >
>  > Addresses a TODO where we were snapping the intrinsic size of an SVG image,
>  > even when that is no longer useful. This was posing issues with operations
>  > using aspect ratio, because the computed aspect ratio on the snapped value
>  > was wrong when then used on un-snapped values.
>  >
>  > R=fs@opera.com
>  > BUG=855882
>  >
>  > Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1370486
>  > Commit-Queue: Stephen Chenney \<schenney@chromium.org>
>  > Reviewed-by: Fredrik Söderquist \<fs@opera.com>
>  > Cr-Commit-Position: refs/heads/master@{#615798}
>  
>  Bug: 855882
>  Change-Id: Icdd1ad0af2aaae6f633b8940522115e9742d1d7f
>  Reviewed-on: https://chromium-review.googlesource.com/c/1373286
>  Reviewed-by: Shuotao Gao \<stgao@chromium.org>
>  Reviewed-by: Fredrik Söderquist \<fs@opera.com>
>  Commit-Queue: Fredrik Söderquist \<fs@opera.com>
>  Cr-Commit-Position: refs/heads/master@{#615840}
>
Component: web-platform-tests → Layout
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a889ac5bb985
[wpt PR 14483] - Reland "Fix SVG-As-Background sizing", a=testonly

https://hg.mozilla.org/mozilla-central/rev/a889ac5bb985

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.