1513780 - Online banking login is no longer triggered by pressing Enter (Easybank, AT)

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Markus Popp]

At my bank's site, I could login pressing Enter after entering my Disposer Number and PIN, until Firefox 64:

https://ebanking.easybank.at/InternetBanking/InternetBanking?d=login&svc=EASYBANK&ui=html&lang=en

In Firefox 65, Enter no longer submits the form. The Login button still works.

Comment 1

[Matthias Versen [:Matti]]

works for me with wrong credentials and Firefox64, Firefox65b4 and Firefox66nightly on windows10
I get the expected "login failed" error message

Comment 2

[Markus Popp]

(In reply to Matthias Versen [:Matti] from comment #1)
> works for me with wrong credentials and Firefox64, Firefox65b4 and
> Firefox66nightly on windows10
> I get the expected "login failed" error message

I use Firefox on Linux, Xubuntu 18.04 64bit to be exact. Maybe it's a Linux only issue.

Comment 3

[Matthias Versen [:Matti]]

This works as well for me in Firefox64 on Xubuntu and Firefox64 on OSX but I can only test with not invalid login credentials.
Do you have extensions installed ?

Comment 4

[Markus Popp]

(In reply to Matthias Versen [:Matti] from comment #3)
> This works as well for me in Firefox64 on Xubuntu and Firefox64 on OSX but I
> can only test with not invalid login credentials.
> Do you have extensions installed ?

I tried with a clean profile and still Enter doesn't submit the form.

I use iBus, in case that plays a role. Recently I reported another keyboard related bug 1508200, there you can find screenshots of my keyboard and iBus settings. Maybe you can duplicate the issue by replicating my keyboard settings.

Comment 5

[Andreas Farre [:farre]]

Markus, could you help us out by trying this with iBus disabled?

Comment 6

[Markus Popp]

(In reply to Andreas Farre [:farre] from comment #5)
> Markus, could you help us out by trying this with iBus disabled?

With iBus disabled, Enter submits the login form. So it's obviously iBus related.

Comment 7

[Andreas Farre [:farre]]

Attachment: keycode.html

So digging into the sources, it looks like the page does 

  if(!window.event){
    if(myEvent.which==13){
      submitLogin(form);
    }
  } else if(window.event.keyCode==13){
    submitLogin(form);
  }

to guard if the form should be submitted. Markus, could you perhaps check so that that keycode is what your iBus keyboard setup sends for 'Enter'? A long shot, but good to make sure. I've attached a file for checking key codes, so you should be confirm this easily.

Comment 8

[Markus Popp]

Key code is 13, so this works right.

Comment 9

[Andreas Farre [:farre]]

Thanks Markus!

Masayuki do you have an idea of what could be happening?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

On 65, window.event becomes available. So, now, we are in the |else if| case in comment 7.

However, if you hit an issue of iBus, it sounds like that dup of bug 1498823. However, we're still not sure what's going on...

Comment 11

[Markus Popp]

This works again and seems to no longer be an issue.