Closed Bug 1513798 Opened Last year Closed Last year

Various OSX simplifications

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
Tracking Status
firefox66 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(13 files, 2 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
I was working on building minidump_stackwalk on automation from the in-tree source in a separate job and was dismayed at the amount of stuff that needed to be done manually.
The script, added in bug 1291028, was obsoleted by bug 1331957.
We're always setting -dead_strip on mac builds, per
cross-mozconfig.common, we might as well not do that and revert bug
638149, which disabled adding -dead_strip with LTO: that is apparently
not a problem anymore.

Depends on D14370
We're always setting -dead_strip on mac builds, per
cross-mozconfig.common, we might as well not do that and revert bug
638149, which disabled adding -dead_strip with LTO: that is apparently
not a problem anymore.

Depends on D14372
Instead of creating symbolic links every time we need it unprefixed.

Depends on D14373
This matches more closely cross toolchains prefixes (as can be seen in
e.g. media/libvpx/libvpx/README for x86_64-darwin*-gcc), and leaves it
to the build system to figure out the right --target to pass to clang on
its own.

Depends on D14375
Attachment #9031038 - Attachment is obsolete: true
Attachment #9031038 - Attachment is obsolete: true
Attachment #9031039 - Attachment is obsolete: true
Instead of passing -B to clang and setting TOOLCHAIN_PREFIX.

Depends on D14377
Because we now set the sysroot include flags early in python configure,
we don't need to set CPP/CXXCPP. We also skip the explicit compiler test
because more complete tests follow anyways.

Depends on D14379
Rather than manually passing -isysroot to clang. Ideally, we shouldn't
need to fill BINDGEN_CFLAGS from the mozconfig, but we're not quite
there yet.

Depends on D14380
Attachment #9031039 - Attachment is obsolete: true
CPP/HOST_CPP were probably not necessary already, but now that we leave
it to configure to figure out the appropriate compiler flags, we don't
need to set HOST_CC/HOST_CXX to remove the flags from CC/CXX.

Depends on D14381
Status: NEW → ASSIGNED
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c1f85400ddf
Remove build/macosx/build-cctools.sh. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/67b2bddb5884
Revert bug 638149 and leave it to configure to set -dead_strip. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/08ad6e1e3244
Ship lipo unprefixed as part of the cctools-port toolchain. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd152b85a5c0
Use a --target that matches what we pass to clang for OSX cross builds. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb20068ba6ea
Use x86_64-darwin11 as a prefix for cctools-port, rather than x86_64-apple-darwin11. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba116be6401
Automatically set TOOLCHAIN_PREFIX when cross-compiling for OSX. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75101881c65
Add cctools/bin to PATH. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/59af907ee8f0
Simplify the handling of --enable-macos-target. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/93d4d156771f
Move --with-macos-{sdk,private-frameworks} to python configure. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf49d8a11b8a
Use --with-macos-sdk for OSX cross build. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/771cdabf7b5a
Don't set HOST_{CC,CXX,CPP} and CPP. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/711a06bf02e5
Expose the linker kind to moz.build. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6513765f487f
Automatically set -syslibroot for OSX cross-builds from configure. r=nalexander
Depends on: 1515604
You need to log in before you can comment on or make changes to this bug.