1513798 - Various OSX simplifications

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

I was working on building minidump_stackwalk on automation from the in-tree source in a separate job and was dismayed at the amount of stuff that needed to be done manually.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Remove build/macosx/build-cctools.sh.

The script, added in bug 1291028, was obsoleted by bug 1331957.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Revert bug 638149 and leave it to configure to set -dead_strip.

We're always setting -dead_strip on mac builds, per
cross-mozconfig.common, we might as well not do that and revert bug
638149, which disabled adding -dead_strip with LTO: that is apparently
not a problem anymore.

Depends on D14370

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Remove build/macosx/build-cctools.sh.

The script, added in bug 1291028, was obsoleted by bug 1331957.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Revert bug 638149 and leave it to configure to set -dead_strip.

We're always setting -dead_strip on mac builds, per
cross-mozconfig.common, we might as well not do that and revert bug
638149, which disabled adding -dead_strip with LTO: that is apparently
not a problem anymore.

Depends on D14372

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Ship lipo unprefixed as part of the cctools-port toolchain.

Instead of creating symbolic links every time we need it unprefixed.

Depends on D14373

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Use a --target that matches what we pass to clang for OSX cross builds.

Depends on D14374

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Use x86_64-darwin11 as a prefix for cctools-port, rather than x86_64-apple-darwin11.

This matches more closely cross toolchains prefixes (as can be seen in
e.g. media/libvpx/libvpx/README for x86_64-darwin*-gcc), and leaves it
to the build system to figure out the right --target to pass to clang on
its own.

Depends on D14375

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Automatically set TOOLCHAIN_PREFIX when cross-compiling for OSX.

Depends on D14376

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Add cctools/bin to PATH.

Instead of passing -B to clang and setting TOOLCHAIN_PREFIX.

Depends on D14377

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Simplify the handling of --enable-macos-target.

Depends on D14378

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Move --with-macos-{sdk,private-frameworks} to python configure.

Because we now set the sysroot include flags early in python configure,
we don't need to set CPP/CXXCPP. We also skip the explicit compiler test
because more complete tests follow anyways.

Depends on D14379

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Use --with-macos-sdk for OSX cross build.

Rather than manually passing -isysroot to clang. Ideally, we shouldn't
need to fill BINDGEN_CFLAGS from the mozconfig, but we're not quite
there yet.

Depends on D14380

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Don't set HOST_{CC,CXX,CPP} and CPP.

CPP/HOST_CPP were probably not necessary already, but now that we leave
it to configure to figure out the appropriate compiler flags, we don't
need to set HOST_CC/HOST_CXX to remove the flags from CC/CXX.

Depends on D14381

Comment 14

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Expose the linker kind to moz.build.

Depends on D14382

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1513798 - Automatically set -syslibroot for OSX cross-builds from configure.

Depends on D14383

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c1f85400ddf
Remove build/macosx/build-cctools.sh. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/67b2bddb5884
Revert bug 638149 and leave it to configure to set -dead_strip. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/08ad6e1e3244
Ship lipo unprefixed as part of the cctools-port toolchain. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd152b85a5c0
Use a --target that matches what we pass to clang for OSX cross builds. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb20068ba6ea
Use x86_64-darwin11 as a prefix for cctools-port, rather than x86_64-apple-darwin11. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba116be6401
Automatically set TOOLCHAIN_PREFIX when cross-compiling for OSX. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75101881c65
Add cctools/bin to PATH. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/59af907ee8f0
Simplify the handling of --enable-macos-target. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/93d4d156771f
Move --with-macos-{sdk,private-frameworks} to python configure. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf49d8a11b8a
Use --with-macos-sdk for OSX cross build. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/771cdabf7b5a
Don't set HOST_{CC,CXX,CPP} and CPP. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/711a06bf02e5
Expose the linker kind to moz.build. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6513765f487f
Automatically set -syslibroot for OSX cross-builds from configure. r=nalexander

Comment 17

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7c1f85400ddf
https://hg.mozilla.org/mozilla-central/rev/67b2bddb5884
https://hg.mozilla.org/mozilla-central/rev/08ad6e1e3244
https://hg.mozilla.org/mozilla-central/rev/dd152b85a5c0
https://hg.mozilla.org/mozilla-central/rev/eb20068ba6ea
https://hg.mozilla.org/mozilla-central/rev/2ba116be6401
https://hg.mozilla.org/mozilla-central/rev/c75101881c65
https://hg.mozilla.org/mozilla-central/rev/59af907ee8f0
https://hg.mozilla.org/mozilla-central/rev/93d4d156771f
https://hg.mozilla.org/mozilla-central/rev/cf49d8a11b8a
https://hg.mozilla.org/mozilla-central/rev/771cdabf7b5a
https://hg.mozilla.org/mozilla-central/rev/711a06bf02e5
https://hg.mozilla.org/mozilla-central/rev/6513765f487f