1513839 - Collect SSL_TIME_UNTIL_HANDSHAKE_FINISHED by key exchange group

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Franziskus Kiefer [:franziskus]]

Attachment: data-review.txt

Telemetry for handshake times should be collected depending on the key exchange group.

Comment 1

[Franziskus Kiefer [:franziskus]]

Attachment: Bug 1513839 - Make SSL_TIME_UNTIL_HANDSHAKE_FINISHED keyed by kea group

This collects SSL_TIME_UNTIL_HANDSHAKE_FINISHED dependent on the key group used. This is nice to have in general and especially for the ecdhe-sidh thing.

Comment 2

[Chris H-C :chutten]

Comment on attachment 9031063 [details]
data-review.txt

Preliminary note:

The answer to question 5 should contain the name, description, relevant bug#, and data collection category of each new or changed collection under review. So we're looking for something like

SSL_TIME_UNTIL_HANDSHAKE_FINISHED_KEYED_BY_KA
ms of SSL wait time for full handshake including TCP and proxy tunneling, keyed by the key exchange algorithm used
bug 1340021
Category 1, Technical

Please include this information (just echo the above if correct and helpful) in a follow-up comment in this bug.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. This collection is Telemetry so it is documented in its definition file (Histograms.json), the Probe Dictionary, and on telemetry.mozilla.org's Measurement Dashboards.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled by Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. Franziskus will monitor it over time.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on, all channels.

    Does the instrumentation include the addition of any new identifiers?

Only categorical ones: the names of key exchange algorithm groups used.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data? 

No. This collection is permanent.

---
Result: datareview+, pending a full list of proposed measurements (Question 5 from the review request)

Comment 3

[Franziskus Kiefer [:franziskus]]

Yep, the full answer for Q5 is:

SSL_TIME_UNTIL_HANDSHAKE_FINISHED_KEYED_BY_KA
ms of SSL wait time for full handshake including TCP and proxy tunneling, keyed by the key exchange algorithm used bug 1340021
Category 1, Technical

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e040d8be2e4
Make SSL_TIME_UNTIL_HANDSHAKE_FINISHED keyed by kea group r=keeler,jcj

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4e040d8be2e4