1513850 - dom/reporting/tests/browser_cleanup.js fails with LSNG enabled

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P2)

Description

[Jan Varga [:janv]]

dom/reporting obviously depends on "extension:purge-localStorage" and "browser:purge-domain-data" being broadcasted even though it was originally intended for localStorage only

Comment 1

[Jan Varga [:janv]]

Attachment: patch

For now, I would just keep these notifications.

Comment 2

[Jan Varga [:janv]]

The try push with failing test:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=00e8a7fd444fcc569218cb4ebd7e62b488df9491&selectedJob=216481411
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216481411&repo=try&lineNumber=8896

Comment 3

[Jan Varga [:janv]]

try push - LSNG disabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b977b87cd6621523a97c6fa5eae5cd3afc2af90

try push - LSNG enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cfb96f5a3684d65a30bd2340e427b4c7e23f7bb

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 9031087 [details] [diff] [review]
patch

Review of attachment 9031087 [details] [diff] [review]:
-----------------------------------------------------------------

Let's file a follow-up against Reporting and cc :baku.  I believe he's working to ensure that the data-clearing APIs use observers less.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eec655e99a2c
dom/reporting/tests/browser_cleanup.js fails with LSNG enabled; r=asuth

Comment 6

[Jan Varga [:janv]]

(In reply to Andrew Sutherland [:asuth] from comment #4)

> Let's file a follow-up against Reporting and cc :baku.  I believe he's
> working to ensure that the data-clearing APIs use observers less.

Filed bug 1515277.

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/eec655e99a2c