1513876 - Implement a API to register a toplevel window global actor.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[John Dai[:jdai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35628e1ae111c788b7997e001019f67e223e9f9a

Comment 2

[John Dai[:jdai]]

This bug will provide registering a Window Actor and an Actor Descriptor Store which holds a mapping from string
names to immutable actor configuration options.

[ChromeOnly]
partial namespace ChromeUtils {
// Register a new toplevel window global actor. This method may only be 
// called in the parent process. |name| must be globally unique. 
[Throws]
void registerWindowActor(DOMString name, WindowActorOptions options);
};

dictionary WindowActorOptions {
// These fields are used for configuring individual sides of the actor. 
required WindowActorSidedOptions parent;
required WindowActorSidedOptions child;
};

dictionary WindowActorSidedOptions {
// The module path which should be loaded for the actor on this side. 
required DOMString module;
};

Comment 3

[John Dai[:jdai]]

|module| is a keyword of python, I'll change to |moduleURI| in the webidl file.

(In reply to John Dai[:jdai] from comment #2) 
> dictionary WindowActorSidedOptions {
> // The module path which should be loaded for the actor on this side. 
> required DOMString module;
> };

0:06.01 Traceback (most recent call last):
 0:06.01   File "/usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 174, in _run_module_as_main
 0:06.02     "__main__", fname, loader, pkg_name)
 0:06.02   File "/usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
 0:06.02     exec code in run_globals
 0:06.02   File "/Users/jdai/src/gecko/python/mozbuild/mozbuild/action/webidl.py", line 19, in <module>
 0:06.02     sys.exit(main(sys.argv[1:]))
 0:06.02   File "/Users/jdai/src/gecko/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
 0:06.02     manager.generate_build_files()
 0:06.02   File "/Users/jdai/src/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 247, in generate_build_files
 0:06.02     self._parse_webidl()
 0:06.02   File "/Users/jdai/src/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 332, in _parse_webidl
 0:06.02     parser.parse(data, path)
 0:06.02   File "/Users/jdai/src/gecko/dom/bindings/parser/WebIDL.py", line 7009, in parse
 0:06.02     self._productions.extend(self.parser.parse(lexer=self.lexer, tracking=True))
 0:06.02   File "/Users/jdai/src/gecko/other-licenses/ply/ply/yacc.py", line 263, in parse
 0:06.02     return self.parseopt(input,lexer,debug,tracking,tokenfunc)
 0:06.02   File "/Users/jdai/src/gecko/other-licenses/ply/ply/yacc.py", line 792, in parseopt
 0:06.02     tok = self.errorfunc(errtoken)
 0:06.02   File "/Users/jdai/src/gecko/dom/bindings/parser/WebIDL.py", line 6948, in p_error
 0:06.02     raise WebIDLError("invalid syntax", [Location(self.lexer, p.lineno, p.lexpos, self._filename)])
 0:06.02 WebIDL.WebIDLError: error: invalid syntax, /Users/jdai/src/gecko/obj-firefox/dom/bindings/ChromeUtils.webidl line 517:21
 0:06.02   required DOMString module;
 0:06.02                      ^

Comment 4

[John Dai[:jdai]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=84b5878fcbf166dccad0021e0f586b5f2ad3c81e

Comment 5

[John Dai[:jdai]]

Attachment: Bug 1513876 - Implement register a toplevel window global actor.

Implement register a toplevel window global actor.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3280e1de13ec
Implement register a toplevel window global actor. r=nika

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd7d39e435d3
Add missing commas. r=eslint-fix

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3280e1de13ec
https://hg.mozilla.org/mozilla-central/rev/fd7d39e435d3