1513898 - Text on screenshot buttons is nearly invisible

Status: UNCONFIRMED

(Firefox :: Screenshots, defect)

Description

[Jaak Ristioja]

Attachment: screenshots.png

User Agent: Mozilla/5.0

Steps to reproduce:

Using Firefox 60.3.0esr.

1) Click ... on the address bar
2) Choose "Take a Screenshot"
3) Look at strange buttons


Actual results:

I felt awkward about the buttons, because they were strangely bright cyan blobs with no descriptive text, no tooltip. After looking at my laptop screen at a slightly different angle I could finally make out the text.


Expected results:

These icons should have been better, the text should have been visible, and there should have been a tooltip.

Comment 1

[Paul_B]

Attachment: Take a screenshot

Hi reporter, 

Thank you for taking the time to report this issue.
I verified this issue on the build you mentioned and on the latest Firefox Versions (Release - 64.0/20181206201918; DevEdition - 65.0b4/20181211223337 and Nightly - 66.0a1/20181217000148) on Mac OS X, Windows 10 and Ubuntu 18.04 but I was not able to reproduce the issue. I have attached a screenshot of the buttons you mentioned. 

Could you please reverify this issue with a clean profile, and maybe even safe mode to eliminate custom settings as a possible cause (https://goo.gl/PNe90E), and report back the results? Could you please also verify the display contrast while doing that in order to make sure it's not a custom setting on that side.

Comment 2

[Jaak Ristioja]

Attachment: firstrun.gif

Here are screenshots from a first run of a new profile on Firefox 60.4.0esr. You can see the hard-to-see text issue elsewhere as well.

I doubt this issue has anything to do with add-ons. I suspect that the developer(s) probably just set the background colour for the buttons but forgot to set the colour for the texts, hence default colours from the system are used. I have my desktop themes configured with dark background and light foreground colours. Most likely there is a missing "color" property in CSS somewhere in Firefox, whereas "background-color" is set. A rather trivial, but extremely common bug on many webpages and software.

Comment 3

[Paul_B]

Given the fact that the issue seems to be related to something that is specific to your setup, could you please try to find a regression range using Mozregression tool?
Information on the tool is available at http://mozilla.github.io/mozregression/. Please don't hesitate to contact us if you encounter any problems.
I'll add this report to Core:Graphics:Text component for a more advised opinion. If this is not the proper component for this, please feel free to change it to a more appropriate one.

Comment 4

[Jaak Ristioja]

No, I will not, and the issue is not that specific, and can be reliably produced on an regular Kubuntu 18.04.1 desktop VM with the latest updates etc. Just switch the GTK-2/GTK-3 themes from KDE System settings (System Settings -> Application Style -> GNOME Application Style (GTK) -> GTK Themes) to Breeze Dark, and there you go.

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

This sounds like a bug in the Firefox Screenshots add-on, not the text rendering system.

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

@Jaak thanks for reporting this.

This issue is similar to bug 1493511. However, I have cloned it into the Screenshots Github repository to be tracked by the development team: https://github.com/mozilla-services/screenshots/issues/4965.