1513917 - Change capitalization for titles in about:addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[emanuela [ux]]

The new titles in about:addons (Manage your {tab-name}) are not following the photon capitalization style (https://design.firefox.com/photon/copy/capitalization.html#title-case:-most-words-are-capitalized).

Extensions tab

current: Manage your themes
desidered: Manage Your Themes

----------

Themes tab

current: Manage your extensions
desidered: Manage Your Extensions

----------

Plugin tab

current: Manage your plugins
desidered: Manage Your Plugins

----------

Dictionaries tab

current: Manage your dictionaries
desidered: Manage Your Dictionaries

----------

Languages tab

current: Manage your languages
desidered: Manage Your Languages

Comment 1

[Mark Striemer [:mstriemer]]

Are you wanting this for 66 or should we just use the new capitalization in the HTML version?

Comment 2

[Meridel [:meridel]]

Hm, I'm afraid I don't know the answer to Mark's question. My response would just be: we should update to title case when we can/whatever is sooner - 66 or HTML version.

Comment 3

[Mark Striemer [:mstriemer]]

The heading string is pulled in extensions.js [1]. Changing the string will require changing the key, `listHeading2.${view.param}` should work. The strings are set in extensions.properties [2].

[1] https://searchfox.org/mozilla-central/rev/47edbd91c43db6229cf32d1fc4bae9b325b9e2d0/toolkit/mozapps/extensions/content/extensions.js#857
[2] https://searchfox.org/mozilla-central/rev/13788edbabb04d004e4a1ceff41d4de68a8320a2/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties#108

Comment 4

[tobias]

Hello,
I would like to work on this.
The request seems very straightforward.
Thanks!

Comment 5

[tobias]

Attachment: Bug 1513917 - Change capitalization for titles in about:addons

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Mark Striemer [:mstriemer] from comment #3)
> The heading string is pulled in extensions.js [1]. Changing the string will
> require changing the key

No need for the new string IDs to change capitalization
https://developer.mozilla.org/en-US/docs/Making_String_Changes

Comment 7

[tobias]

Cool!
So the docs say to add the checkin-needed tag, but I do not seem to be able to do this, or cannot find the place to do it. Could someone please advise?
Thanks!

Comment 8

[Andrew Swan [:aswan]]

tobias, sorry this wasn't documented better, you need to click "Edit Bug" in the upper right corner, then find the "Keywords" section and enter "checkin-needed", then submit the change.
Let us know if you have any trouble, and thanks for your contribution!

Comment 9

[Mark Striemer [:mstriemer]]

Hey, I actually just hit the button to land it in phabricator. It should make it's way to Nightly for tomorrow.

Thanks for your contribution!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b376f9e62911
Change capitalization for titles in about:addons r=mstriemer,aswan

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b376f9e62911