1513927 - check_for_crashes deletes crash files

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

Because mozcrash is silly, check_for_crashes actually deletes the crash files, so a subsequent call to log_crashes doesn't do anything. This badly need to be refactored, but in the meantime change things around so that we only call log_crashes and use the return value from that to actually check if any crashes occured.

Comment 1

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ca26b6d71e3213d687bb59949d1fc24462faee1 may or may not show a crash that indicates whether or not this works.

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1513927 - Change wpt crash handling API to be a single method,

Because mozcrash is stateful we can't check for crashes and then later
log them; we need to do everything in one shot. Therefore remove the
check_for_crashes call, rename log_crash to check_crash and make it
return a boolean indicating whether any crashes occured, as well as
handling the logging.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/517fdabf94bd
Change wpt crash handling API to be a single method, r=ted

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14517 for changes under testing/web-platform/tests

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/517fdabf94bd

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged