TransactionTooLargeException when app with a Private tab is put in background
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox64+ verified, firefox65+ verified, firefox66 verified)
People
(Reporter: petru, Assigned: petru)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release+
|
Details | Review |
Assignee | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 6•6 years ago
|
||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
bugherder |
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Comment 17•6 years ago
|
||
bugherder uplift |
Comment 18•6 years ago
|
||
Updated•6 years ago
|
Comment 19•6 years ago
|
||
Jan or Petru, what do you think about getting this in to 64.0.2? Please request uplift to release if you think it appropriate (crash volume on beta seems to have dropped massively in 65.0b8).
Assignee | ||
Comment 20•6 years ago
|
||
Comment on attachment 9032631 [details]
Bug 1513938 - Enforce a Bundle size limit and drop privateSession
if exceeds it; r?JanH
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Private browsing/session store
User impact if declined: If the user has a private browsing session with a large amount of session history data, Firefox may crash when it goes into the background.
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: No
Needs manual test from QE?: Yes
If yes, steps to reproduce: see comment #2 / comment #9
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This patch is just dropping the private browsing session store data if it exceed a certain amount. This doesn't lead to an ideal user experience (because the user's private browsing tabs will be lost if we're OOM-killed later on), but it still is better than crashing.
String changes made/needed:
Comment 21•6 years ago
|
||
Comment on attachment 9032631 [details]
Bug 1513938 - Enforce a Bundle size limit and drop privateSession
if exceeds it; r?JanH
address fennec top crasher, approved for 64.0.2. Thanks!
Comment 22•6 years ago
|
||
bugherder uplift |
Comment 23•6 years ago
|
||
Couldn't reproduce the issue by following the steps from comment #9 on 64.0.2 RC Build 1. Marking 64 as verified.
Updated•4 years ago
|
Description
•