1513947 - Cannot pin hash in FROM statement in Dockerfile: DIND socket is too old.

Status: RESOLVED WONTFIX

(Taskcluster :: Workers, defect)

Description

[Johan Lorenzo [:jlorenzo]]

I wanted to solve bug 1513296 which is a one liner[1]. Sadly, build-docker-image-firefox-snap jobs are unhappy with this change[2]:

> [task 2018-12-12T13:05:22.818Z] executing ['sh', '-x', '-c', '   /builds/worker/checkouts/gecko/mach taskcluster-build-image   -t "firefox-snap:b2e56228ef5e2f1c1f889673c04b614c8ad3094c4397488302158be1fbdb3938"   "firefox-snap"']
> [task 2018-12-12T13:05:22.820Z] + /builds/worker/checkouts/gecko/mach taskcluster-build-image -t firefox-snap:b2e56228ef5e2f1c1f889673c04b614c8ad3094c4397488302158be1fbdb3938 firefox-snap
> [task 2018-12-12T13:05:23.250Z] Step 0 : FROM snapcore/snapcraft@sha256:53c9ca5c1bed50451ec68571a76884c36f906976fd37a45cda2ef5b840206caf
> [task 2018-12-12T13:05:23.418Z] Pulling repository snapcore/snapcraft
> [task 2018-12-12T13:05:24.191Z] Repository not found
> kill 9

I am sure this is not a type in the patch[1] because: 
a. I manage to build the Dockerfile locally
b. The repository does exist, because mozilla-central builds with it.

I managed to run 1-click-loaner[3] to inspect what's in image_builder. I discovered DIND (Docker in Docker)[4] is done by talking directly to the Unix socket. Therefore, there is no docker client in image_builder. Once installed, I get:

> docker info 
> Error response from daemon: client and server don't have same version (client : 1.24, server: 1.18)

API 1.18 equals docker 1.6[5]. Docker 1.6 is the first version to ever support digests in FROM statements (in Dockerfiles)[6]. My guess is: even though it's supported, it was the very first version and maybe it's bugged. A version bump would probably fix this.


[1] https://hg.mozilla.org/try/rev/7938b139a006714b8daebb00d0d5a39bdec2dab2
[2] For instance: https://tools.taskcluster.net/groups/MnEGCSJ-QyqiylNJKzaAnA/tasks/PhcaP8cIQvaiu8rfUd_Raw/runs/1/logs/public%2Flogs%2Flive_backing.log#L107
[3] I worked around bug 1513540 by using task creator to fill the missing tag. 
[4] https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/taskcluster/taskgraph/docker.py#90
[5] https://docs.docker.com/develop/sdk/#api-version-matrix
[6] https://docs.docker.com/v1.6/reference/builder/#from compared https://docs.docker.com/v1.5/reference/builder/#from

Comment 1

[Johan Lorenzo [:jlorenzo]]

May be solved by bug 1501720 - an upgrade of DIND was tried.