Closed
Bug 1513950
Opened 5 years ago
Closed 5 years ago
The cpp-virtual-final lint doesn't run on .cc files
Categories
(Developer Infrastructure :: Source Code Analysis, defect, P3)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox65 wontfix, firefox66 fixed)
RESOLVED
FIXED
mozilla66
People
(Reporter: ehsan.akhgari, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
status-firefox65:
--- → wontfix
status-firefox66:
--- → affected
Component: General → Source Code Analysis
Priority: -- → P3
Product: Core → Firefox Build System
|
|
Assignee | |
Comment 1•5 years ago
|
||
At this time, there are no cpp-virtual-final warnings in any .cc files. :) Also: 1. Remove unnecessary exclusion of node_modules because the directory contains no C++ code that would be checked by this lint. 2. Update number of virtual-override instances that prevent us from checking for `virtual void Bad() override`.
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/605aa74c29e3 Run cpp-virtual-final lint on .cc files. r=ahal
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/605aa74c29e3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•