Closed Bug 1513950 Opened 10 months ago Closed 10 months ago

The cpp-virtual-final lint doesn't run on .cc files

Categories

(Firefox Build System :: Source Code Analysis, defect, P3)

Product:
Firefox Build System
Component:
Source Code Analysis
Type:
defect

Tracking

(firefox65 wontfix, firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: ehsan, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Bug 1513950 - Run cpp-virtual-final lint on .cc files. r?ahal
47 bytes, text/x-phabricator-request
Details | Review
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
status-firefox65: --- → wontfix
status-firefox66: --- → affected
Component: General → Source Code Analysis
Priority: -- → P3
Product: Core → Firefox Build System
At this time, there are no cpp-virtual-final warnings in any .cc files. :)

Also:

1. Remove unnecessary exclusion of node_modules because the directory contains no C++ code that would be checked by this lint.

2. Update number of virtual-override instances that prevent us from checking for `virtual void Bad() override`.
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/605aa74c29e3
Run cpp-virtual-final lint on .cc files. r=ahal
https://hg.mozilla.org/mozilla-central/rev/605aa74c29e3
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.