1513951 - Load presets from an in-tree file in addition to the one in mozbuild state dir

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement)

Description

[Andrew Halberstadt [:ahal]]

I think it would go a long way to have a file in-tree that teams can edit to add global presets that can be used by anyone. For example, the devtools team could add a preset that runs all the recommended jobs that normally affect files under /devtools.

Then new developers/contributors can just run:

./mach try --preset devtools

without needing to copy/paste a big long try syntax (or fuzzy query). In the event an in-tree preset clashes with a user defined preset, the user defined one should take precedence.

I'd like to revamp the preset system a bit before working on this though.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1513951 - [tryselect] Pass preset path into PresetHandler's constructor

This will make it possible to have multiple instances of PresetHandler to
support multiple preset files.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1513951 - [mach] Fix error handling bug in config.py

Depends on D21429

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1513951 - [tryselect] Add some documentation for presets

Depends on D21430

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1513951 - [tryselect] Implement in-tree try_presets.yml file

This creates a global preset file at:
tools/tryselect/try_presets.yml

Any presets defined here will be available for everyone to use.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ea24e73acf5
[tryselect] Pass preset path into PresetHandler's constructor r=gbrown
https://hg.mozilla.org/integration/autoland/rev/74de0c0022dc
[tryselect] Implement in-tree try_presets.yml file r=gbrown
https://hg.mozilla.org/integration/autoland/rev/c66965245aaa
[tryselect] Add some documentation for presets r=gbrown
https://hg.mozilla.org/integration/autoland/rev/a6c5017346c4
[mach] Fix error handling bug in config.py r=gbrown

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3ea24e73acf5
https://hg.mozilla.org/mozilla-central/rev/74de0c0022dc
https://hg.mozilla.org/mozilla-central/rev/c66965245aaa
https://hg.mozilla.org/mozilla-central/rev/a6c5017346c4