Closed Bug 1513951 Opened 9 months ago Closed 7 months ago

Load presets from an in-tree file in addition to the one in mozbuild state dir

Categories

(Firefox Build System :: Try, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(4 files)

I think it would go a long way to have a file in-tree that teams can edit to add global presets that can be used by anyone. For example, the devtools team could add a preset that runs all the recommended jobs that normally affect files under /devtools.

Then new developers/contributors can just run:

./mach try --preset devtools

without needing to copy/paste a big long try syntax (or fuzzy query). In the event an in-tree preset clashes with a user defined preset, the user defined one should take precedence.

I'd like to revamp the preset system a bit before working on this though.
Depends on: 1518572
Severity: normal → enhancement
Blocks: 1529048
Assignee: nobody → ahal
Status: NEW → ASSIGNED

This will make it possible to have multiple instances of PresetHandler to
support multiple preset files.

Attachment #9047177 - Attachment description: Bug 1513951 - [tryselect] Implement in-tree try_presets.yml file → Bug 1513951 - [mach] Fix error handling bug in config.py

This creates a global preset file at:
tools/tryselect/try_presets.yml

Any presets defined here will be available for everyone to use.

Blocks: 1531886
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ea24e73acf5
[tryselect] Pass preset path into PresetHandler's constructor r=gbrown
https://hg.mozilla.org/integration/autoland/rev/74de0c0022dc
[tryselect] Implement in-tree try_presets.yml file r=gbrown
https://hg.mozilla.org/integration/autoland/rev/c66965245aaa
[tryselect] Add some documentation for presets r=gbrown
https://hg.mozilla.org/integration/autoland/rev/a6c5017346c4
[mach] Fix error handling bug in config.py r=gbrown
You need to log in before you can comment on or make changes to this bug.