1513969 - Add telemetry to track the active time usage of the grid highlighter

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

This is add telemetry that will measure how long the grid highlighter is ON for (however or how many grid highlighters are activated). If 1 or more highlighter are active, we count the time up, and if 0 are active we don’t. So the actual number of enabled highlighters doesn’t matter.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1513969.patch [1.0]

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: data-review.txt

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92b3ba31f7d086030d21a47ecbff15f6e5a91c13

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 9031230 [details] [diff] [review]
1513969.patch [1.0]

Review of attachment 9031230 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/shared/highlighters-overlay.js
@@ +43,5 @@
>      // associated with any NodeFront.
>      this.extraGridHighlighterPool = [];
>  
> +    // Boolean flag to keep track of whether or not the telemetry timer for the grid
> +    // highlighter active time is active. We keep track of this because an existing timer

I suggest rephrasing this a bit. I don't find the last sentence very clear.

We keep track of this to avoid re-starting a new timer when an additional grid highlighter is turned on.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9031232 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

This collection is Telemetry so it is documented in its definition file (Histograms.json), in the Probe Dictionary, and on telemetry.mozilla.org's Measurement Dashboards.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. This collection is Telemetry so is controlled by Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. :mbalfanz will monitor.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data? 

No. The collection is permanent.

---
Result: datareview+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3d28129f1d
Add telemetry to track the active time usage of the grid highlighter. r=pbro

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ea3d28129f1d