Open Bug 1513981 Opened 5 years ago Updated 2 months ago

Investigate timestamp shift in bug history on 2016-05-25

Categories

(bugzilla.mozilla.org :: Administration, task)

Production
task
Not set
normal

Tracking

()

People

(Reporter: marco, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

Similarly in bug 1148030, with the keyword #relman/triage/defer-to-group.
In bug 1398424, the bug should have STR and regression range, but both of them are missing from the REST API.

Maybe these cases are all cases for which this data was removed from the DB? E.g. in bug 1398424 maybe the product was moved to NSS, and NSS doesn't have those flags? Maybe these changes should be reflected in the history too?
Blocks: 1513955
Component: API → General

(In reply to Marco Castelluccio [:marco] from comment #0)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1274602 and see that
'checkin-needed' is not in 'keywords' in
https://bugzilla.mozilla.org/rest/bug/1274602.

The history actually contains the checkin-needed keyword, both in added and removed, but weird enough, the order is wrong.

mysql> SELECT * FROM bugs_activity WHERE bug_id = 1274602 AND DATE(bug_when) = '2016-05-25';
+---------+--------+---------+----------------+-----------------------------+-----------+------------+-----------+---------------------+
| bug_id  | who    | fieldid | removed        | added                       | attach_id | comment_id | id        | bug_when            |
+---------+--------+---------+----------------+-----------------------------+-----------+------------+-----------+---------------------+
| 1274602 | 176914 |      54 | 0              | 1                           |   8755141 |       NULL | 306658519 | 2016-05-25 12:56:03 |
| 1274602 | 176914 |      69 |                | review+                     |   8756317 |       NULL | 306658520 | 2016-05-25 12:56:03 |
| 1274602 | 176914 |      21 |                | checkin-needed              |      NULL |       NULL | 306658542 | 2016-05-25 13:00:57 |
| 1274602 | 510726 |      21 | checkin-needed |                             |      NULL |       NULL | 306659720 | 2016-05-25 07:33:45 |
| 1274602 | 308534 |      29 | ASSIGNED       | RESOLVED                    |      NULL |       NULL | 306662167 | 2016-05-25 15:36:33 |
| 1274602 | 308534 |      30 |                | FIXED                       |      NULL |       NULL | 306662168 | 2016-05-25 15:36:33 |
| 1274602 | 308534 |      40 | ---            | mozilla49                   |      NULL |       NULL | 306662169 | 2016-05-25 15:36:33 |
| 1274602 | 308534 |     184 |                | 2016-05-25 22:36:33         |      NULL |       NULL | 306662170 | 2016-05-25 15:36:33 |
| 1274602 | 308534 |     696 | ---            | fixed                       |      NULL |       NULL | 306662171 | 2016-05-25 15:36:33 |
| 1274602 | 176914 |      37 |                | rkent@caspia.com            |      NULL |       NULL | 306663138 | 2016-05-25 22:22:53 |
| 1274602 | 176914 |      69 |                | needinfo?(rkent@caspia.com) |      NULL |       NULL | 306663139 | 2016-05-25 22:22:53 |
+---------+--------+---------+----------------+-----------------------------+-----------+------------+-----------+---------------------+
11 rows in set (0.00 sec)

mysql> SELECT comment_id, who, bug_when, SUBSTR(thetext, 1, 10) FROM longdescs WHERE bug_id = 1274602 AND DATE(bug_when) = '2016-05-25';
+------------+--------+---------------------+------------------------+
| comment_id | who    | bug_when            | SUBSTR(thetext, 1, 10) |
+------------+--------+---------------------+------------------------+
|   11436913 | 176914 | 2016-05-25 12:56:03 | Fixed revi             |
|   11436926 | 176914 | 2016-05-25 13:00:57 | Dear Sheri             |
|   11437388 | 510726 | 2016-05-25 07:33:45 | https://hg             |
|   11439079 | 308534 | 2016-05-25 15:36:33 | https://hg             |
|   11439817 | 176914 | 2016-05-25 22:22:53 | Kent, plea             |
+------------+--------+---------------------+------------------------+
5 rows in set (0.00 sec)

07:33:45 is likely a wrong timestamp, perhaps related to the time zone migration but not sure. Will check other cases.

(In reply to Marco Castelluccio [:marco] from comment #1)

Similarly in bug 1148030, with the keyword #relman/triage/defer-to-group.

The #relman/triage/defer-to-group and #relman/triage/needs-info keywords were added but later removed in Bug 696898. These were not simply disabled, so only the activity log retains them.

mysql> SELECT bug_id, removed, added FROM bugs_activity WHERE fieldid = 21 AND (removed LIKE '%#relman/triage%' OR added LIKE '%#relman/triage%');
+---------+-----------------------------------+--------------------------------------------------------------+
| bug_id  | removed                           | added                                                        |
+---------+-----------------------------------+--------------------------------------------------------------+
|  684308 |                                   | #relman/triage/needs-info                                    |
|  691370 |                                   | #relman/triage/needs-info                                    |
|  660394 |                                   | #relman/triage/needs-info                                    |
|  687610 |                                   | #relman/triage/defer-to-group                                |
|  696579 |                                   | #relman/triage/needs-info                                    |
|  697833 |                                   | #relman/triage/defer-to-group                                |
|  698342 |                                   | #relman/triage/needs-info                                    |
|  698344 |                                   | #relman/triage/needs-info                                    |
|  691951 |                                   | #relman/triage/needs-info                                    |
|  699826 |                                   | #relman/triage/needs-info                                    |
|  699826 | #relman/triage/needs-info         |                                                              |
|  700302 |                                   | #relman/triage/needs-info                                    |
|  700302 | #relman/triage/needs-info         |                                                              |
|  689924 |                                   | #relman/triage/needs-info                                    |
|  701212 |                                   | #relman/triage/needs-info                                    |
|  693182 |                                   | #relman/triage/needs-info, qawanted, regressionwindow-wanted |
|  693811 |                                   | #relman/triage/needs-info                                    |
|  705026 |                                   | #relman/triage/defer-to-group                                |
|  704693 |                                   | #relman/triage/defer-to-group                                |
|  697981 |                                   | #relman/triage/needs-info                                    |
|  697981 | #relman/triage/needs-info         |                                                              |
|  704482 |                                   | #relman/triage/needs-info, sec-review-needed                 |
|  696579 | #relman/triage/needs-info         |                                                              |
|  704482 | #relman/triage/needs-info         |                                                              |
|  707855 |                                   | #relman/triage/needs-info                                    |
|  679971 |                                   | #relman/triage/defer-to-group                                |
|  715756 |                                   | #relman/triage/defer-to-group                                |
|  694084 |                                   | #relman/triage/defer-to-group                                |
|  694084 | #relman/triage/defer-to-group     | verifyme                                                     |
|  690980 | checkin-needed                    | #relman/triage/defer-to-group                                |
|  679649 |                                   | #relman/triage/needs-info                                    |
|  679649 | #relman/triage/needs-info         |                                                              |
|  740778 | qawanted, regressionwindow-wanted | #relman/triage/defer-to-group                                |
|  307181 | sec-review-needed                 | #relman/triage/defer-to-group, sec-review-complete           |
|  665578 |                                   | #relman/triage/needs-info                                    |
|  735199 |                                   | #relman/triage/needs-info                                    |
|  753775 | qawanted                          | #relman/triage/defer-to-group                                |
|  753775 | #relman/triage/defer-to-group     |                                                              |
|  726500 | checkin-needed                    | #relman/triage/defer-to-group                                |
|  726500 | #relman/triage/defer-to-group     |                                                              |
|  756663 |                                   | #relman/triage/defer-to-group, uiwanted                      |
|  769336 |                                   | #relman/triage/defer-to-group                                |
|  769336 | #relman/triage/defer-to-group     |                                                              |
|  775536 |                                   | #relman/triage/defer-to-group                                |
|  791170 |                                   | #relman/triage/needs-info                                    |
|  791170 | #relman/triage/needs-info         |                                                              |
|  794805 |                                   | #relman/triage/needs-info                                    |
|  794859 |                                   | #relman/triage/defer-to-group                                |
|  794859 | #relman/triage/defer-to-group     |                                                              |
|  827131 |                                   | #relman/triage/defer-to-group                                |
|  827131 | #relman/triage/defer-to-group     |                                                              |
|  845768 |                                   | #relman/triage/defer-to-group                                |
|  845768 | #relman/triage/defer-to-group     |                                                              |
|  846405 |                                   | #relman/triage/needs-info                                    |
|  846405 | #relman/triage/needs-info         |                                                              |
|  627813 |                                   | #relman/triage/needs-info                                    |
|  278536 |                                   | #relman/triage/needs-info                                    |
|  861375 | #relman/triage/needs-info         |                                                              |
|  879200 |                                   | #relman/triage/needs-info                                    |
|  731498 |                                   | #relman/triage/needs-info                                    |
|  939422 |                                   | #relman/triage/defer-to-group                                |
|  939422 | #relman/triage/defer-to-group     |                                                              |
|  959110 |                                   | #relman/triage/needs-info                                    |
|  961463 |                                   | #relman/triage/defer-to-group                                |
|  988240 |                                   | #relman/triage/defer-to-group                                |
|  993826 | access                            | #relman/triage/defer-to-group                                |
|  993826 | #relman/triage/defer-to-group     |                                                              |
| 1041768 |                                   | #relman/triage/defer-to-group                                |
| 1041768 | #relman/triage/defer-to-group     |                                                              |
|  989715 | qawanted                          | #relman/triage/needs-info                                    |
|  989715 | #relman/triage/needs-info         |                                                              |
| 1059693 | regressionwindow-wanted           | #relman/triage/needs-info                                    |
| 1059693 | #relman/triage/needs-info         |                                                              |
| 1075235 |                                   | #relman/triage/needs-info                                    |
| 1099400 |                                   | #relman/triage/needs-info                                    |
| 1099400 | #relman/triage/needs-info         |                                                              |
| 1129990 |                                   | #relman/triage/needs-info                                    |
| 1129990 | #relman/triage/needs-info         |                                                              |
|  959110 | #relman/triage/needs-info         |                                                              |
| 1137687 |                                   | #relman/triage/defer-to-group                                |
| 1137687 | #relman/triage/defer-to-group     |                                                              |
| 1142188 |                                   | #relman/triage/defer-to-group                                |
| 1142188 | #relman/triage/defer-to-group     |                                                              |
| 1147697 |                                   | #relman/triage/defer-to-group                                |
| 1147697 | #relman/triage/defer-to-group     |                                                              |
| 1170229 | #relman/triage/defer-to-group     |                                                              |
| 1172498 |                                   | #relman/triage/defer-to-group, sec-high                      |
| 1172498 | #relman/triage/defer-to-group     |                                                              |
| 1175968 |                                   | #relman/triage/defer-to-group                                |
| 1176524 | #relman/triage/defer-to-group     |                                                              |
| 1014545 |                                   | #relman/triage/defer-to-group                                |
| 1177703 | #relman/triage/defer-to-group     |                                                              |
| 1178486 | #relman/triage/defer-to-group     |                                                              |
| 1184217 |                                   | #relman/triage/defer-to-group, leave-open                    |
| 1186208 | #relman/triage/defer-to-group     |                                                              |
| 1148030 |                                   | #relman/triage/defer-to-group, dev-doc-needed                |
+---------+-----------------------------------+--------------------------------------------------------------+
96 rows in set (20.80 sec)

(In reply to Marco Castelluccio [:marco] from comment #2)

In bug 1398424, the bug should have STR and regression range, but both of
them are missing from the REST API.

Both are in the history. Check for cf_has_str and cf_has_regression_range.

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #5)

(In reply to Marco Castelluccio [:marco] from comment #2)

In bug 1398424, the bug should have STR and regression range, but both of
them are missing from the REST API.

Both are in the history. Check for cf_has_str and cf_has_regression_range.

Yeah, this case was fixed by bug 1514411.

The main problem here (and in other related bugs) is that the information in the history is not the same as the information shown on the UI or not the same as the information in the 'current bug data' returned by the REST API.

(In reply to Marco Castelluccio [:marco] from comment #6)

The main problem here (and in other related bugs) is that the information in the history is not the same as the information shown on the UI or not the same as the information in the 'current bug data' returned by the REST API.

I know, but the causes are different.

Will check other bugs as well to figure out what can I do with each issue.

This is when the timestamp moved back 7 hours, perhaps from UTC to PDT?

+-----------+---------------------+
| id        | bug_when            |
+-----------+---------------------+
| 306659613 | 2016-05-25 14:13:00 |
| 306659614 | 2016-05-25 07:13:41 |
+-----------+---------------------+
Summary: 1274602 has checkin-needed keyword, but the REST API doesn't return checkin-needed in the list of keywords → Investigate timestamp shift in bug history on 2016-05-25
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Type: defect → task

Perhaps Dylan remembers what happened here?

Flags: needinfo?(dylan)

That was probably the UTC conversion, the date/time check out I think?

Flags: needinfo?(dylan)

I was thinking about it but 2016-05-25 was Wednesday. When did the PST/UTC conversion happen exactly?

Assignee: kohei.yoshino → nobody
Status: ASSIGNED → NEW
Component: General → Administration

Is this work still needed?

Flags: needinfo?(mcastelluccio)

It's not high priority at all, but it is nice to have.

Flags: needinfo?(mcastelluccio)
Attachment #9387483 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: