Closed Bug 1514007 Opened 10 months ago Closed 9 months ago

Show the script type (classic normal|async|defer or module normal|async) in the profiler

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: smaug, Assigned: mstange)

Details

Attachments

(1 file)

Right now we show just "<script> element", but would helpful to have more information.
See
https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/dom/script/ScriptLoader.cpp#2241

See the image in 
https://html.spec.whatwg.org/#attr-script-async
Priority: -- → P3
This also moves the label from ScriptLoader::ProcessScriptElement to
ScriptLoader::EvaluateScript so that it also kicks in for scripts that are run
from NotifyOffThreadScriptLoadCompletedRunnable::Run.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/bf7da92f820b
Annotate <script> evaluation profiler labels with async/defer. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.