1514025 - Create a top sites section component for Activity Stream experiment functionality

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

We need this to be something we can turn on and off, and can land in nightly 66 without breaking any existing functionality.

It needs designs still, but I can attach wire frames.

This one seems to be the most straight forward, and might be the best candidate to use the existing topsites component and not being a new component.

Comment 1

[Scott [:thecount] Downe]

Attachment: topsites.png

Comment 2

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/commit/24acf31365fee54ab637fb17afd3aaa8d8af5640

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Comment 4

[Scott [:thecount] Downe]

Testing instructions:

1. Ensure the new tab is the regular version by default.
2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/e90dd44a9f7bddaef8b4f2895221f58d/raw/523b05a06d57ad1ca726ec60596af64c8eb6188a/test"}
3. Ensure new tab is rendering something different than default, and also with a bunch of topsites icons. These icons should match the default, the rest of the page should look different.
4. Reset the pref, ensure everything is back to normal.

Comment 5

[Brahmini Nagabandi]

FF Nightly version 66.0a1 (2019-01-16)

OS : Mac and Windows 10

I don't see any difference before and after pref change. Topsites icons are same as they are.

Comment 6

[Scott [:thecount] Downe]

Sorry, my instructions were too brief and I didn't quite take care to explain that the thing is different in some areas and the same in others. I updated my original instructions and hopefully it's more clear now. (I would provide a screenshot but the data is changing pretty quickly and I thought that might be more troublesome.)

Comment 7

[Brahmini Nagabandi]

Hi, I still don't see any difference in layout with the new pref change. Below is the test data.

FF Nightly version : 66.0a1 (2019-01-20)

OS : Mac and Windows 10 Pro

I made sure pref has default value initially and then changed, no difference in layout.

Comment 8

[Scott [:thecount] Downe]

There was a typo in my pref after I edited it the first time, fixed it and edited the original comment again, should work now.

Comment 9

[Brahmini Nagabandi]

Attachment: QA Result New Pref value : bug 1514025.png

QA Results :

Tested on :

FF Nightly version : 66.0a1 (2019-01-23)

OS : Mac and Windows 10 Pro

QA steps :

Tested with 2 different pref settings :

1. Changed browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/e90dd44a9f7bddaef8b4f2895221f58d/raw/523b05a06d57ad1ca726ec60596af64c8eb6188a/test"}

Result :
Attachment - QA Result New Pref value : bug 1514025.png

2. Changed browser.newtabpage.activity-stream.discoverystream.config 's default feed enabled set to true

Result :
Attachment - QA Result (enabled set to "true") / bug 1514025

Comment 10

[Brahmini Nagabandi]

Attachment: QA Result (enabled set to "true") : bug 1514025.png

Comment 11

[Brahmini Nagabandi]

Works as expected.

Closing as verified.