Closed Bug 1514027 Opened 6 years ago Closed 6 years ago

Create a topics header section component for Activity Stream experiment functionality

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

topics.png
95.47 KB, image/png
Details
We need this to be something we can turn on and off, and can land in nightly 66 without breaking any existing functionality. It needs designs still, but I can attach wire frames.
Attached image topics.png —
Blocks: 1513353
Assignee: nobody → sdowne
Severity: normal → enhancement
Iteration: --- → 66.1 - Dec 10-23
Priority: -- → P1
Blocks: 1512725
Iteration: 66.1 - Dec 10-23 → 66.2 - Dec 24 - Jan 6
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
Blocks: 1519243

Fixed by https://github.com/mozilla/activity-stream/commit/049d1f0f229001a4df5004160ec2c9f96827f276

Some follow-up work will be done in https://bugzilla.mozilla.org/show_bug.cgi?id=1519243 to get styling to spec

Status: NEW → RESOLVED
Iteration: 66.3 - Jan 7 - 20 → 67.1 - Jan 28 - Feb 10
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Iteration: 67.1 - Jan 28 - Feb 10 → 66.3 - Jan 7 - 20

https://hg.mozilla.org/mozilla-central/rev/bd9fccec51d7

Blocks: 1517867
Target Milestone: --- → Firefox 66

Testing instructions:

  1. Ensure the new tab is the regular version by default.
  2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/5ddadf1e238aaae1ad1bfcaf32f37530/raw/1fea64bff7615d3593b923f1794a14e18e83dc08/topics-layout"}
  3. Ensure new tab is rendering something different than default, in this case, three "more recommendations" links.
  4. Reset the pref, ensure everything is back to normal.

Verified on :

FF Nightly Version - 66.0a1 (2019-01-14)
OS - Mac

Did basic testing. Search, add/remove pages via Pocket Tile.

Looks good to me.

Thanks,
Brahmini

Verified on :

FF Nightly Version - 66.0a1 (2019-01-15)

OS - Windows 10 Pro N

Did basic testing. Search, add/remove pages via Pocket Tile.

Looks good to me.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: