The statusbar of the message filter windows looks funny

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago
Found this reviewing bug 1511644.

Richard, can you please take a look.
Flags: needinfo?(richard.marti)
Assignee

Comment 1

5 months ago
After the de-XBLification of the statusbar, the status-bar is now a <hbox>. We had rules to add margins to hbox and this applied now to the status-bar too.

I added IDs to apply the rules only to the needed elements.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9031350 - Flags: review?(jorgk)
Reporter

Comment 2

5 months ago
Comment on attachment 9031350 [details] [diff] [review]
1514068-filterListDialog.patch

Looks great now. That needs to go into TB 65, right?
Attachment #9031350 - Flags: review?(jorgk)
Attachment #9031350 - Flags: review+
Attachment #9031350 - Flags: approval-comm-beta+
Assignee

Comment 3

5 months ago
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 9031350 [details] [diff] [review]
> 1514068-filterListDialog.patch
> 
> Looks great now. That needs to go into TB 65, right?

I think yes.
Keywords: checkin-needed

Comment 4

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/948685252daa
Use IDs for correct rules selection in FilterListDialog to correct statusbar. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.