[wpt-sync] Sync PR 14510 - Update for RTCQuicStream.write() function.

RESOLVED FIXED in Firefox 66

Status

enhancement
P4
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

6 months ago
Sync web-platform-tests PR 14510 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14510
Details from upstream follow.

Seth Hampson <shampson@chromium.org> wrote:
>  Update for RTCQuicStream.write() function.
>  
>  Combines functionality of finish() into write() by adding a new
>  QuicStreamWriteParameters input parameter that includes a finish
>  boolean. This is consistent with the latest spec draft and also adds
>  symmetry between readInto() and write().
>  
>  Bug: 874296
>  Change-Id: I0def0ca25587ebf00a4b179ce8e9e7a124c818f6
>  Reviewed-on: https://chromium-review.googlesource.com/1376720
>  WPT-Export-Revision: 1bb469b8e52663b5f540d3a2649aa4c3ecdaab1c
Assignee

Comment 4

6 months ago
Ran 1 tests and 71 subtests
OK     : 1
FAIL   : 71

New tests that have failures or other problems:
/webrtc-quic/RTCQuicStream.https.html
    Pending waitForWriteBufferedAmountBelow() promises rejected after write() with finish.: FAIL
    Reading out finish on stream that has already called write() with a finish  state to 'closed'.: FAIL
    Stream closed by by reading remote finish, followed by writing a finish: readInto() throws InvalidStateError.: FAIL
    Stream closed by by reading remote finish, followed by writing a finish: waitForReadable() rejects with InvalidStateError.: FAIL
    Stream closed by by reading remote finish, followed by writing a finish: waitForWriteBufferedBelow() rejects with InvalidStateError.: FAIL
    Stream closed by by reading remote finish, followed by writing a finish: write() throws InvalidStateError.: FAIL
    Stream closed by writing a finish, followed by reading remote finish: readInto() throws InvalidStateError.: FAIL
    Stream closed by writing a finish, followed by reading remote finish: waitForReadable() rejects with InvalidStateError.: FAIL
    Stream closed by writing a finish, followed by reading remote finish: waitForWriteBufferedBelow() rejects with InvalidStateError.: FAIL
    Stream closed by writing a finish, followed by reading remote finish: write() throws InvalidStateError.: FAIL
    reset() following write with finish changes state to 'closed'.: FAIL
    waitForReadable() promise resolves with remote finish: FAIL
    waitForReadable() resolves with write() with finish.: FAIL
    waitForWriteBufferedAmountBelow() promises immediately rejected after wrote finish.: FAIL
    write() data with a finish adds to writeBufferedAmount.: FAIL
    write() throws InvalidStateError if write() with finish has been called.: FAIL
    write() with a finish causes quicstream event to fire on the remote transport.: FAIL
    write() with a finish changes state to 'closing'.: FAIL
    write() with a finish on a stream that has already read out finish changes state to 'closed'.: FAIL
    write() with finish twice throws InvalidStateError.: FAIL
    write() without finish and an empty array throws NotSupportedError.: FAIL
    writeBufferedAmount maintained after write() with finish has been called.: FAIL
    writeBufferedAmount set to 0 after reading remote finish, followed by write() with finish.: FAIL

Comment 6

5 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/990811660670
[wpt PR 14510] - Update for RTCQuicStream.write() function., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2b2c1fa37b3
[wpt PR 14510] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.