Closed Bug 1514111 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14513 - rename XRDevicePose to XRViewerPose

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14513 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14513
Details from upstream follow.

Jacob DeWitt <jacde@chromium.org> wrote:
>  rename XRDevicePose to XRViewerPose
>  
>  - Rename files to reflect the XR API change I am about to make that renames XRDevicePose to XRViewerPose and XRFrame.getDevicePose to XRFrame.getViewerPose Also update the build files to handle the new filenames.
>  - Update blink XR code files to rename XRDevicePose to XRViewerPose and rename XRFrame.getDevicePose to XRFrame.getViewerPose. This is one of several changes required to make Chromium conform to the latest version of the web XR API standards, which are at https://github.com/immersive-web/webxr/blob/master/explainer.md#appendix-b-proposed-idl
>  - Update test files and expected test output to use the new names XRViewerPose and XRFrame.getViewerPose after the API changes. global-interface-listing-expected.txt expected test output needs to have interfaces and methods in alphabetical order.
>  
>  Bug: 914978
>  Change-Id: I60801cab151ef44d9f88a59c1caed2d65def7b51
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1377142
>  WPT-Export-Revision: 786ffab40173f54f01753b81debc96e5036581ac
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 21 tests and 28 subtests
OK     : 21
PASS   : 2
FAIL   : 26

New tests that have failures or other problems:
/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html
    XRFrame getViewerPose updates on the next frame for immersive sessions: FAIL
    XRFrame getViewerPose updates on the next frame for non-immersive sessions: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65fc5b4213d5
[wpt PR 14513] - Rename XRDevicePose to XRViewerPose, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/714d665c38bf
[wpt PR 14513] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a65c56c261fc
[wpt PR 14513] - Rename XRDevicePose to XRViewerPose, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/aae1525c5649
[wpt PR 14513] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.