1514170 - $(...)[0] is undefined in panel.js:121:5

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Frederik Braun [:freddy]]

I get this error in the console:
> TypeError: $(...)[0] is undefined[Learn More] panel.js:121:5


The code around the error is as follows:
>    // If the user toggles the checkbox let's update the state accordingly.
>    $('#panel-accel-enable')[0].addEventListener('change', () => {
>        var newState = ($('#panel-accel-enable')[0].checked);
>        updateAccelerators(newState);
>    });


​

Comment 1

[Frederik Braun [:freddy]]

Attachment: GitHub Pull Request

Comment 2

[Kartikaya Gupta (email:[e-mail])]

What URL are you seeing this on? The panel.js code should only be getting included on patches that have the checkbox. If the checkbox isn't there it might be a different bug somewhere.

Comment 3

[Frederik Braun [:freddy]]

I get it on <https://searchfox.org/> directly

Comment 4

[Kartikaya Gupta (email:[e-mail])]

So I think removing panel.js from https://github.com/mozsearch/mozsearch/blob/dbfae5e0817254ba3b043ad482f55d6cae251e06/scripts/output.js#L137 would work too since I believe that file is only used by pages that don't actually have panels. But I guess in the future we might want to add panels there too so the approach in your patch is fine too.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 9031369 [details] [review]
GitHub Pull Request

Minusing for now because of https://github.com/mozsearch/mozsearch/pull/171#issuecomment-449208703

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This landed a while ago