1514181 - Replace browser/themes/osx/toolbarbutton-dropmarker{,@2x}.png with arrow-dropdown-12.svg

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Tim Nguyen :ntim]

Those 2 files can be removed:
browser/themes/osx/toolbarbutton-dropmarker.png
browser/themes/osx/[e-mail]

This code can be removed:
https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/places/organizer.css#94-103

https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/jar.mn#15-16

The usage at:
https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/places/organizer.css#89

can be replaced with chrome://global/skin/icons/arrow-dropdown-12.svg

Comment 1

[Vedant]

I'd like to take this up and work on it if possible

Comment 2

[Tim Nguyen :ntim]

Sure, please let me know if you have any questions!

Comment 3

[Vedant]

Hi Tim,

Shouldn't this set of lines also be removed?

https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/places/organizer.css#88-93

Comment 4

[Vedant]

Nevermind, I just realized that's the block within which we have to do the line replacement that you mentioned. Thanks!

Comment 5

[Vedant]

Attachment: Bug 1514181 - Replace browser/themes/osx/toolbarbutton-dropmarker{,@2x}.png with arrow-dropdown-12.svg

Comment 6

[Tim Nguyen :ntim]

Thanks for the patch!

Note that you forgot to remove the two files in question in the revision. 

You can do:
hg rm browser/themes/osx/toolbarbutton-dropmarker.png
hg rm browser/themes/osx/[e-mail]

to ensure they get removed.

Comment 7

[Vedant]

Attachment: Bug 1514181 Replace browser/themes/osx/toolbarbutton-dropmarker{,@2x}.png with arrow-dropdown-12.svg

Depends on D15406

Comment 8

[Vedant]

Hi Tim,

Yup I realized that and had changed it. I was just waiting on Phabricator to go through all the commits. I think it should all be as intended now. Please let me know if anything else needs to be changed. Thanks!

Comment 9

[Tim Nguyen :ntim]

Looks pretty good now, thanks! Would it be possible to get both commits squashed into one ? Please let me know if you have any questions regarding this :)

Comment 10

[Vedant]

Hi Tim,

I'm not fully certain how to do this with Mercurial. Some information would be much appreciated. Thanks!

Comment 11

[Tim Nguyen :ntim]

(In reply to Vedant from comment #10)
> Hi Tim,
> 
> I'm not fully certain how to do this with Mercurial. Some information would
> be much appreciated. Thanks!

You can use `hg histedit` and use the `roll` command on the top commit.

Comment 12

[Vedant]

Alright, I think commit D15406 should have all the combined changes now.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84b5a122d74e
Replace browser/themes/osx/toolbarbutton-dropmarker{,@2x}.png with arrow-dropdown-12.svg r=dao

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/84b5a122d74e