Closed
Bug 1514189
Opened 5 years ago
Closed 5 years ago
Build bustage in gc/Verifier.cpp: error: base operand of ‘->’ has non-pointer type ‘mozilla::DebugOnly<JS::Zone*>’
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: decoder, Assigned: jonco)
References
Details
Attachments
(1 file)
1.10 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Detected by fuzzing builds this morning, regressed by bug 1513465. In file included from js/src/gc/Unified_cpp_js_src_gc2.cpp:2:0: js/src/gc/Verifier.cpp: In function ‘bool js::gc::CheckWeakMapEntryMarking(const js::WeakMapBase*, js::gc::Cell*, js::gc::Cell*)’: js/src/gc/Verifier.cpp:786:35: error: base operand of ‘->’ has non-pointer type ‘mozilla::DebugOnly<JS::Zone*>’ CellColor valueColor = valueZone->isGCMarking() ? GetCellColor(value) ^~
Assignee | ||
Comment 1•5 years ago
|
||
Remove the DebugOnly<> from valueZone so that it's present in non-debug builds where GC zeal is enabled.
Attachment #9031399 -
Flags: review?(jdemooij)
Comment 2•5 years ago
|
||
Comment on attachment 9031399 [details] [diff] [review] bug1514189-fix-fuzz-builds Review of attachment 9031399 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #9031399 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e4aa68e2a85b Fix build bustage in opt builds with --enable-gczeal r=jandem
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4aa68e2a85b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•