1514204 - [RTL] Tracking protection animation ends (and stays that way) with the purple shield instead of a black/white one

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Itiel]

Attachment: Tracking protection animation

I *think* this is a regression caused by bug 1506996, but I'm not sure and can't verify this at the moment.

STR:
Be on default/dark theme, open www.bbc.com and watch the tracking protection animation on the address bar.

AR:
At the very end on the animation, the shield slowly turns black (on the default theme) or white (on the dark theme) but eventually the shield turns back to be purple.

ER:
It should stay black/white.

Comment 1

[Itiel]

(In reply to Itiel from comment #0)
> I *think* this is a regression caused by bug 1506996

Now confirmed, but this happens only on RTL.

So, new STR:
1. Change intl.uidirection to 1
2. Be on default/dark theme
3. Open www.bbc.com and observe the tracking protection animation

Comment 2

[(no longer active)]

If I had to guess, I would expect this had to do with either of these two places not being correctly updated:

https://hg.mozilla.org/mozilla-central/rev/a72dafbb2e80#l1.27
https://hg.mozilla.org/mozilla-central/rev/a72dafbb2e80#l1.111

Erica, any chance you could have a look, please?  Thanks!

Comment 3

[Erica Wright [:ewright]]

Attachment: Bug 1514204 - [RTL] Tracking protection animation properly ends with a grey shield.

In rtl the shield animation previously would remain purple after ending, now it remains grey, equivalent to ltr.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47b081238ac7
[RTL] Tracking protection animation properly ends with a grey shield. r=dao

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9032772 [details]
Bug 1514204 - [RTL] Tracking protection animation properly ends with a grey shield.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Users in rtl locals will have a bright purple shield showing after the animation ends, instead of a dimmer grey one.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: - go to about:config
- set the pref intl.uidirection to 1
- go to about:preferences then privacy & security
- set content blocking category to "strict"
- visit https://bugzilla.mozilla.org/
- observe the shield animation
- repeat in dark mode

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): not risky, css pixel change

String changes made/needed: none

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/47b081238ac7

Comment 7

[Itiel]

Fixed now on latest Nightly. Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9032772 [details]
Bug 1514204 - [RTL] Tracking protection animation properly ends with a grey shield.

[Triage Comment]
Simple CSS fix for a minor UI issue. Approved for 65.0b7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/be15ceade8ab

Comment 10

[Damira Akh]

Verified
20181226093642
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Comment 11

[Damira Akh]

Followed STR.
Tracking protection animation turned from gray to light purple and ended with a gray shield.

Verified on following builds
Build ID 20181226093642
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Build ID 20181227144402
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0