Closed Bug 1514239 Opened 11 months ago Closed 11 months ago

Move certificate export dialog to use fluent

Categories

(Firefox :: Preferences, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Splitting this off from bug 1513710 because we can't uplift this.

This isn't a good first / mentored bug because the error message strings are bit funky. Copying from IRC:

13:45:44 <@Gijs> stas: hi. I'm a bit confused by the deprecation of Variants in favour of parameterized Terms. In particular, it seems I can't pass variables to a term, so I don't understand how to use them in that case... E.g. putting this into the playground works: https://gist.github.com/gijsk/022297a86f20df9eddccf6d8dd550db2
13:46:00 <@Gijs> stas: but replacing "access-denied" with $error gives a parsing error, as does wrapping the $error in {} .
13:46:41 <@Gijs> stas: my understanding is that we're not "supposed" to translate 1 string and then substitute it back into another string (which is what the pre-fluent string does here)
13:46:46 <@Gijs> so what's the "correct" solution?
13:47:14 <@Gijs> duplicating the same thing 5 times also seems stupid :(

For reference, the original strings are here: 
https://searchfox.org/mozilla-central/source/security/manager/locales/en-US/chrome/pippki/pippki.properties#96-100

Hoping either :flod or :gandalf can suggest something here - I guess stas is out...
Flags: needinfo?(gandalf)
Flags: needinfo?(francesco.lodolo)
I talked to Dana, let's just use whatever OS.File comes back with.
Flags: needinfo?(gandalf)
Flags: needinfo?(francesco.lodolo)
Attachment #9031528 - Attachment description: Bug 1514239 - use fluent for the certificate export code in the cert manager → Bug 1514239 - use fluent for the certificate export code in the cert manager, r?flod!,keeler!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(In reply to :Gijs (he/him) from comment #0)
> Splitting this off from bug 1513710 because we can't uplift this.
> 
> This isn't a good first / mentored bug because the error message strings are
> bit funky. Copying from IRC:
> 
> 13:45:44 <@Gijs> stas: hi. I'm a bit confused by the deprecation of Variants
> in favour of parameterized Terms. In particular, it seems I can't pass
> variables to a term, so I don't understand how to use them in that case...
> E.g. putting this into the playground works:
> https://gist.github.com/gijsk/022297a86f20df9eddccf6d8dd550db2

I need a bit more time to think if this is a good approach in terms of localizability, but I'm surprised that this wouldn't work. Note that the macro syntax is new (like, today new), and I'm not sure if the playground is already up to date.
(In reply to Francesco Lodolo [:flod] from comment #3)
> (In reply to :Gijs (he/him) from comment #0)
> > Splitting this off from bug 1513710 because we can't uplift this.
> > 
> > This isn't a good first / mentored bug because the error message strings are
> > bit funky. Copying from IRC:
> > 
> > 13:45:44 <@Gijs> stas: hi. I'm a bit confused by the deprecation of Variants
> > in favour of parameterized Terms. In particular, it seems I can't pass
> > variables to a term, so I don't understand how to use them in that case...
> > E.g. putting this into the playground works:
> > https://gist.github.com/gijsk/022297a86f20df9eddccf6d8dd550db2
> 
> I need a bit more time to think if this is a good approach in terms of
> localizability, but I'm surprised that this wouldn't work. Note that the
> macro syntax is new (like, today new), and I'm not sure if the playground is
> already up to date.

I mean, it's moot now, because per discussion with Dana (see comment #1), I decided to just remove the custom error message work here. Given the context (an error dialog for certificate export) it doesn't seem worth over-rotating on the ergonomics. Approximately nobody should ever see this.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/96fdb239f5bc
use fluent for the certificate export code in the cert manager, r=flod,keeler
https://hg.mozilla.org/mozilla-central/rev/96fdb239f5bc
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.