Closed
Bug 1514252
Opened 5 years ago
Closed 5 years ago
Force 160 dpi and device-pixel ratio of 1.0 in TestRunnerActivity
Categories
(GeckoView :: General, enhancement)
GeckoView
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: snorp, Assigned: snorp)
References
Details
Attachments
(1 file)
Depending on the device/emulator, we'll sometimes have a device-pixel ratio of 3.625 or similar, which because of app units ends up being something like 3.63<lots more digits>. This causes rounding errors with direct comparisons in mochitest/reftests. I think the existing Fennec emulators force a scale of 1.0, but we can just do this in TestRunnerActivity since we support it in GeckoRuntimeSettings.
|
Assignee | |
Updated•5 years ago
|
Blocks: geckoview_mochitest
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → snorp
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8326406ad7b4 Use 160 DPI and a device pixel scale of 1.0 for GeckoView tests. r=geckoview-reviewers,mbrubeck#geckoview-reviewers
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8326406ad7b4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Target Milestone: Firefox 66 → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•