Closed Bug 1514254 Opened 5 years ago Closed 5 years ago

Need to run ./mach clang-format once from the commandline before rebasing using clang-format

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jesup, Assigned: andi)

References

Details

Attachments

(1 file)

After ./mach bootstrap, you seem to still need to do ./mach clang-format to ensure all the clang-tools are installed locally before a rebase across the clang-format landing boundary will work.  Without that, you get a "abort: clang-format: mach exited with status 1"; with --debug you get:

running /home/jesup/src/mozilla/inbound/mach clang-format --assume-filename $HG_FILENAME -p /tmp/tmpljnkqW.h
   result clang-format: Unable to set locate clang-format tools

Re-doing ./mach bootstrap doesn't solve it.  Doing ./mach clang-format does, however, cause the missing tool (clang-tidy?  it scrolled out of my terminal history) to be installed.

I think this may be fallout from Bug 1510637
Assignee: nobody → bpostelnicu
Can you please post the output of mach bootstrap?
Flags: needinfo?(rjesup)
Attached file bootstrap.out
Flags: needinfo?(rjesup)
Note: i remove npm from the update list because it kills bootstrap due to my having nodejs2 installed
Priority: -- → P3

Does this still happen, I think not since we've changed a lot of the way how we deal with clang-format and it's artifact in the meantime.

Flags: needinfo?(rjesup)

Probably not an issue, but install/bootstrap/rebase patch that triggers clang-format would be the sequence to test.

Flags: needinfo?(rjesup)

Closing this as this is no longer a present issue.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: