Closed Bug 1514296 Opened Last year Closed 5 months ago

Feature Policy: Rename document.policy to document.featurePolicy

Categories

(Core :: DOM: Security, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ckerschb, Assigned: baku)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: dev-doc-needed, Whiteboard: [domsecurity-backlog1] [domsecurity-active])

Attachments

(3 files)

As described within [1] we should update document.policy to document.featurePolicy. Further, we would also have to update our tests within [2] to reflect that change.

[1] https://github.com/WICG/feature-policy/issues/216
[2] dom/security/featurepolicy/test/mochitest/test_parser.html
Baku, can you take on that work?
Flags: needinfo?(amarchesini)
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
Attachment #9031676 - Flags: review?(ckerschb)
Blocks: 1514474
Comment on attachment 9031676 [details] [diff] [review]
part 1 - renaming

As agreed on slack I am clearing the r? for now till we have figured things out with regards to the spec.
Attachment #9031676 - Flags: review?(ckerschb)

Were there still open spec issues we were concerned with, :ckerschb?

I was hoping to implement bug 1442689, and would love to see the web platform tests passing. If we're no longer blocked, and just have to rename to featurePolicy() and add the features() method, I don't mind helping out with that too?

Flags: needinfo?(ckerschb)

Thomas, please see bug 1531012. We're holding off on Feature Policy for now.

Flags: needinfo?(ckerschb)

Depends on D35802

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a43f3aa0ea77
Rename Document.policy to Document.featurePolicy, r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/52ae606e4cfa
FeaturePolicy - WPT fixed, r=ckerschb

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=52ae606e4cfa4334c1ea549298f37efe10bdb414&selectedJob=254595196

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=254595196&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f78b95447137397f60c7d7e0a8eb6a7a00793d23

[task 2019-07-03T14:17:07.228Z] 14:17:07 INFO - TEST-PASS | dom/security/featurepolicy/test/mochitest/test_featureList.html | Feature: document-domain
[task 2019-07-03T14:17:07.229Z] 14:17:07 INFO - Buffered messages finished
[task 2019-07-03T14:17:07.230Z] 14:17:07 INFO - TEST-UNEXPECTED-FAIL | dom/security/featurepolicy/test/mochitest/test_featureList.html | Feature: display-capture
[task 2019-07-03T14:17:07.231Z] 14:17:07 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-07-03T14:17:07.236Z] 14:17:07 INFO - checkFeatures/<@dom/security/featurepolicy/test/mochitest/test_featureList.html:28:5
[task 2019-07-03T14:17:07.236Z] 14:17:07 INFO - checkFeatures@dom/security/featurepolicy/test/mochitest/test_featureList.html:27:12
[task 2019-07-03T14:17:07.237Z] 14:17:07 INFO - @dom/security/featurepolicy/test/mochitest/test_featureList.html:33:1
[task 2019-07-03T14:17:07.239Z] 14:17:07 INFO - TEST-PASS | dom/security/featurepolicy/test/mochitest/test_featureList.html | Feature: speaker

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe343795c247
Rename Document.policy to Document.featurePolicy, r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/88f4a687f039
FeaturePolicy - WPT fixed, r=ckerschb
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Regressions: 1563960
Status: RESOLVED → REOPENED
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Target Milestone: mozilla69 → ---
Duplicate of this bug: 1563960
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25fe2e2d6c70
Rename Document.policy to Document.featurePolicy, r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/e152b48eb48f
FeaturePolicy - WPT fixed, r=ckerschb
Flags: needinfo?(amarchesini)

Because the bug has still the status open and the fix not been merged to central yet.

Flags: needinfo?(amarchesini)

Noemi imported the patches landed on autoland and used them for beta sim that's why the needinfo for Andrea.

Sorry about missing that. Andrea, please see comment 15.

Flags: needinfo?(amarchesini)
Keywords: leave-open

I'm confused, is it landed? All except the WPT patch?

Flags: needinfo?(amarchesini) → needinfo?(nbeleuzu)

I discussed this issue with ccoroiu and, it seems that in the yesterday simulation, all was fine.

Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Flags: needinfo?(nbeleuzu)
Resolution: --- → FIXED
Regressions: 1564229
You need to log in before you can comment on or make changes to this bug.