Closed Bug 1514322 Opened 6 years ago Closed 6 years ago

Assert against GL errors

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(3 files, 1 obsolete file)

Right now we don't do any error checking, so errors can pile up, and people don't realize when they add invalid code.

I'm just going to do a basic patch to assert after every frame that there are no errors here. Doing the checking per-call can be a followup.
Priority: -- → P3
These enums are extensions, meaning that they aren't necessarily
supported. This checking is just nice-to-have, so I'm dropping it rather
than adding support for detecting these extensions.
Depends on D14650
Depends on: stage-wr-trains
Blocks: stage-wr-trains
No longer blocks: stage-wr-next
No longer depends on: stage-wr-trains
Whoops, sorry, I messed up the state. I meant this to not block the MVP and depend on wr-future-update. Fixing that now.
Blocks: stage-wr-next
No longer blocks: stage-wr-trains
Depends on: 1514735
Attachment #9031630 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: