1514322 - Assert against GL errors

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Bobby Holley (:bholley)]

Right now we don't do any error checking, so errors can pile up, and people don't realize when they add invalid code.

I'm just going to do a basic patch to assert after every frame that there are no errors here. Doing the checking per-call can be a followup.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e5be22a3acb0eb1b2deb54c77a875d158ff19e2

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 1514322 - Drop code for detecting GLContext tampering.

These enums are extensions, meaning that they aren't necessarily
supported. This checking is just nice-to-have, so I'm dropping it rather
than adding support for detecting these extensions.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Bug 1514322 - Crop uploads to texture size.

Depends on D14650

Comment 4

[Bobby Holley (:bholley)]

Attachment: Bug 1514322 - Assert against GL errors in debug builds.

Depends on D14651

Comment 5

[Bobby Holley (:bholley)]

Attachment: Bug 1514322 - Check framebuffer completeness after setup.

Depends on D14652

Comment 6

[Bobby Holley (:bholley)]

https://github.com/servo/webrender/pull/3428

Comment 7

[Bobby Holley (:bholley)]

Whoops, sorry, I messed up the state. I meant this to not block the MVP and depend on wr-future-update. Fixing that now.