Closed Bug 1514337 Opened 2 years ago Closed 2 years ago

Activity Stream layout pref and layout data for rapid experimentation

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.1 - Dec 10-23
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

We need to be able to pref this new layout config feature on and off.

We also need to be able to pull the data from the pocket server, and get that layout configuration over to the client's jsx.

This bug alone probably won't create any visible changes, but maybe create an example component for testing purposes?
Blocks: 1513353, 1513253
Assignee: nobody → sdowne
Does there need to be an actual pref vs the code path just being unused until appropriate data from the server activates it?
See Also: → 1513312
Iteration: --- → 66.1 - Dec 10-23
Priority: -- → P1
Blocks: 1512725
Severity: normal → enhancement
Blocks: 1514913
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/325b45ae967e4ffa629eb3f78cabcfdd48993622
Fix Bug 1514337 - Activity Stream layout pref and layout data for rapid experimentation (#4593)

* Fix Bug 1514337 - Activity Stream layout pref and layout data for rapid experimentation

* lint

* Adding tests a a few tweaks.

* bug fix

* removing use_layout pref

* Updates to tests

* test updates

* deepEqual usage
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1515206

Hi,

Could you please provide some details on how this can be tested. Thanks.

Flags: needinfo?(sdowne)

This patch was an quick and early attempt at what we refined in https://bugzilla.mozilla.org/show_bug.cgi?id=1516008

Testing instructions are essentially the same:

  1. Ensure the new tab is the regular version by default.
  2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
  3. Ensure new tab is rendering something different than default.
  4. Reset the pref, ensure everything is back to normal.
Flags: needinfo?(sdowne)

FF Nightly version 66.0a1 (2019-01-16)

OS : Mac and Windows 10

qq:
Is it intentional to have large sized cards on the new tab?
Also,I could only see More Recommendations section and not other sections - Top sites/Recommended by Pocket/Highlights.

Flags: needinfo?(sdowne)

That looks like a bug in that component. Probably not an issue with this ticket.

Flags: needinfo?(sdowne)

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-18)

OS : Mac and Windows 10

Below are the observations :

  • New tab renders different layout with pref changes, functionality works as expected.
  • After Pref reset, New Tab gets back the default version and functionality works as expected.

Looks good to me.

Thanks,
Brahmini

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.