1514389 - Animated transform flashes when the rasterization scale changes

Status: RESOLVED DUPLICATE of bug 1505363

(Core :: Graphics: WebRender, defect, P4)

Description

[Markus Stange [:mstange]]

Steps to reproduce:
 1. Open https://perfht.ml/2LjQBka
 2. Click the [...] button at the top, next to the string "Firefox (66.0) Intel Mac OS X 10.10".

Expected results:
A panel should appear with a transform animation.

Actual results:
During the animation, the panel is very blurry. Then it briefly disappears, and then it becomes sharp.

It shouldn't disappear.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

mstange, can you create a reduced test case?

Comment 2

[Darkspirit]

Looked fine before.

1. Regression: Broken shadow, displaced, cut-off.
mozregression --good 2018-03-01 --bad 2018-05-01 --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
> 14:08.18 INFO: Last good revision: 48e344feb212edf648879380b877151fb4c29ec6
> 14:08.18 INFO: First bad revision: 0c721699dba5fdcf8d1fafe9aeb845532349bb59
> 14:08.18 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=48e344feb212edf648879380b877151fb4c29ec6&tochange=0c721699dba5fdcf8d1fafe9aeb845532349bb59

> 0c721699dba5	Kartikaya Gupta — Bug 1419851 - Handle OMTA throttling for webrender. r=jrmuizel

2. Improved, small at first, but not massively broken anymore.
mozregression --find-fix --bad 2018-04-10 --good 2018-10-21 --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
> 12:06.01 INFO: First good revision: 45261374e05f4a047667ac21a813084dc9a90a2b
> 12:06.01 INFO: Last bad revision: 493e812d03421d640f1111e57373d6c4d777f789
> 12:06.01 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=493e812d03421d640f1111e57373d6c4d777f789&tochange=45261374e05f4a047667ac21a813084dc9a90a2b

> 45261374e05f	Emilio Cobos Álvarez — Bug 1497239 - Properly apply inherited scale to filters. r=jrmuizel

3. Improved, today's behavior:
mozregression --find-fix --bad 2018-04-10 --good 2018-12-10 --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
> 14:31.75 INFO: First good revision: 3ef66c8d682c099b0ccb8bc41d2fd678dc39d29a
> 14:31.75 INFO: Last bad revision: 29c73665ba1923bbb91cebfc3f785e8c7471522b
> 14:31.75 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=29c73665ba1923bbb91cebfc3f785e8c7471522b&tochange=3ef66c8d682c099b0ccb8bc41d2fd678dc39d29a

> 3ef66c8d682c	Emilio Cobos Álvarez — Bug 1498221 - Don't apply layer scaling to fallback filters. r=mattwoodrow

Comment 3

[Darkspirit]

Attachment: 2018-12-15_00-20-21.mp4

Before: mozregression --repo autoland --launch 48e344feb212edf648879380b877151fb4c29ec6 --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
1. mozregression --repo autoland --launch 0c721699dba5fdcf8d1fafe9aeb845532349bb59 --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
2. mozregression --repo autoland --launch 45261374e05f4a047667ac21a813084dc9a90a2b --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka
3. mozregression --repo autoland --launch 3ef66c8d682c099b0ccb8bc41d2fd678dc39d29a --pref gfx.webrender.all:true -a https://perfht.ml/2LjQBka

Comment 4

[Markus Stange [:mstange]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> mstange, can you create a reduced test case?

Not before I'm on PTO unfortunately. If somebody else wants to try: It's an SVG filtered element inside an animated transform.
Filter: https://github.com/devtools-html/perf.html/blob/f12bbc2a0f527ff7a79d87a35f9866d5b939ff19/src/components/shared/ArrowPanel.css#L24
Transform animation: https://github.com/devtools-html/perf.html/blob/f12bbc2a0f527ff7a79d87a35f9866d5b939ff19/src/components/shared/ArrowPanel.css#L49-L67

Comment 5

[Markus Stange [:mstange]]

I no longer see any flashing!

Comment 6

[Darkspirit]

Fix range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=816dcd83b0c4677f417056766ee2b3223ff78822&tochange=ed51ef14289e378f05974012b62f1cb2464b867b