Closed Bug 1514493 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14541 - WIP: Async Clipboard ReadImage/WriteImage prototype.

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 14541 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14541
Details from upstream follow.

Darwin Huang <huangdarwin@chromium.org> wrote:
>  WIP: Async Clipboard ReadImage/WriteImage prototype.
>  
>  API Goal:
>  - Async Clipboard functionality to ReadImage() and WriteImage()
>  - JS side will send Blobs with MIME type "image/png"
>  - Images will be "safe", as we'll re-encode to strip potentially dangerous
>  metadata and protect from arbitrary code execution. Only image types
>  supported by the Skia library will be supported for this initial POC.
>  - First release into experimental with this ReadImage()/WriteImage()
>  - Later integrate into Read()/Write() and remove ReadImage()/WriteImage()
>  
>  Features:
>  - FileReader used to read Blobs asynchronously.
>  - Image Decoding on a separate thread.
>  - Image read/write accomplished, where Images are represented by Blobs holding
>  MIME type "image/png"
>  - Manual test requires user to copy the green image and then refresh.
>  
>  Future work:
>  - Image encoding on a separate thread as well.
>  - Simplify and determine what code runs on which threads.
>  - Move PNGCodec off of async clipboard area?
>  - Improve test to be automatic instead of manual, and to not require user copy.
>  - Consider use of ImageBitmapFactory increased types available for accessing the
>  async clipboard, and reduction in potentially duplicate code, at the cost of
>  a potential for increased complexity.
>  
>  Bug: 150835
>  Change-Id: I4380116642b4720bb9773185eb2e28757688c5ec
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1345090
>  WPT-Export-Revision: 862cd3859300a53b0e25174ea97896a9e301efda
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/434971de57eb
[wpt PR 14541] - Async Clipboard: ReadImageExperimental/WriteImageExperimental, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93e8279ba244
[wpt PR 14541] - Async Clipboard: ReadImageExperimental/WriteImageExperimental, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.