1514500 - Context menu for tabs is overloaded and very dangerous

Status: RESOLVED INVALID

(Firefox :: Menus, defect)

Description

[-]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Imagine you have 600 tabs open, you're on the first one and accidentally click on "close tabs to the right".


Actual results:

All tabs are gone, except the first one.


Expected results:

Nothing. This function is dangerous, remove it immediately!

Also, the rest of the context menu is now overloaded with other functions, which I doubt the majority of users has any use for them.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
20181206201918

Attempting to close 2 or more tabs results in a prompt like the following:

[ Close tabs? ]

You are about to close 2 tabs. Are you sure you want to continue?
< Close tabs > < Cancel >

The only way this doesn't happen is if browser.tabs.warnOnCloseOtherTabs has been set to false in about:config.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Gingerbread Man is right - in the scenario you describe, there _should_ be a dialog that appears before closing the 599 other tabs.

Reporter, do you have browser.tabs.warnOnCloseOtherTabs set to false?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(If the answer is "yes", I suspect this is a WONTFIX)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)
> (If the answer is "yes", I suspect this is a WONTFIX)

(I actually think INVALID is probably more appropriate)

I'm going to close as INVALID for now, since we already provide a warning dialog. If there's a case where we're unexpectedly _not_ showing that warning dialog, we can re-open this.