Closed Bug 1514514 Opened 7 years ago Closed 7 years ago

Use TextMarkers (with Docshells) for all PageLoad timing Markers

Categories

(Core :: Gecko Profiler, enhancement, P3)

Product:
Core
Component:
Gecko Profiler
Version:
57 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file, 2 obsolete files)

Move pageload markers to TextMarker with DocShell IDs
5.77 KB, patch
mstange
: review+
Details | Diff | Splinter Review
It will be much easier to view, find and indicate in the profiler UI if we normalize the pageload markers to use TextMarkers (and to filter by DocShell).
added log statements for DCL/FCP/FNBP
Attachment #9031714 - Flags: review?(mstange)
Attachment #9031711 - Attachment is obsolete: true
Attachment #9031711 - Flags: review?(mstange)
Attachment #9031714 - Attachment is obsolete: true
Attachment #9031714 - Flags: review?(mstange)
Priority: -- → P3
Comment on attachment 9035350 [details] [diff] [review] Move pageload markers to TextMarker with DocShell IDs Review of attachment 9035350 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, except for the NS_ConvertASCIItoUTF16 calls which should go away if you make the change I requested in bug 1508837 comment 6.
Attachment #9035350 - Flags: review?(mstange) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/39104a14a66b Move pageload markers to TextMarker with DocShell IDs r=mstange

https://hg.mozilla.org/mozilla-central/rev/39104a14a66b

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: