Use TextMarkers (with Docshells) for all PageLoad timing Markers

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

57 Branch
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

It will be much easier to view, find and indicate in the profiler UI if we normalize the pageload markers to use TextMarkers (and to filter by DocShell).
added log statements for DCL/FCP/FNBP
Attachment #9031714 - Flags: review?(mstange)
Attachment #9031711 - Attachment is obsolete: true
Attachment #9031711 - Flags: review?(mstange)
Attachment #9031714 - Attachment is obsolete: true
Attachment #9031714 - Flags: review?(mstange)
Priority: -- → P3
Comment on attachment 9035350 [details] [diff] [review]
Move pageload markers to TextMarker with DocShell IDs

Review of attachment 9035350 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, except for the NS_ConvertASCIItoUTF16 calls which should go away if you make the change I requested in bug 1508837 comment 6.
Attachment #9035350 - Flags: review?(mstange) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39104a14a66b
Move pageload markers to TextMarker with DocShell IDs r=mstange
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.