Closed Bug 1514577 Opened 6 years ago Closed 1 year ago

Intermittent browser/components/newtab/test/browser/browser_topsites_section.js | Uncaught exception - TypeError: topsiteEl.querySelector(...) is null

Categories

(Firefox :: New Tab Page, defect, P5)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure)

Filed by: ncsoregi [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=217273342&repo=autoland https://queue.taskcluster.net/v1/task/OmLz7MbRTtKcCUG1Mdy9Sg/runs/0/artifacts/public/logs/live_backing.log [task 2018-12-16T11:27:24.210Z] 11:27:24 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_topsites_section.js | should find 1 pinned topsite - 1 == 1 - [task 2018-12-16T11:27:24.213Z] 11:27:24 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_topsites_section.js | Should find a context menu button - {} == true - [task 2018-12-16T11:27:24.214Z] 11:27:24 INFO - Buffered messages finished [task 2018-12-16T11:27:24.215Z] 11:27:24 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_topsites_section.js | Uncaught exception - TypeError: topsiteEl.querySelector(...) is null [task 2018-12-16T11:27:24.217Z] 11:27:24 INFO - Leaving test bound topsites_pin_unpin [task 2018-12-16T11:27:24.219Z] 11:27:24 INFO - Entering test bound topsites_add [task 2018-12-16T11:27:24.220Z] 11:27:24 INFO - GECKO(2251) | ++DOCSHELL 0x7f4941910800 == 7 [pid = 2428] [id = {8758c497-466f-43d6-ba4e-287e2610fac3}] [task 2018-12-16T11:27:24.221Z] 11:27:24 INFO - GECKO(2251) | ++DOMWINDOW == 18 (0x7f493ecde400) [pid = 2428] [serial = 60] [outer = (nil)] [task 2018-12-16T11:27:24.222Z] 11:27:24 INFO - GECKO(2251) | ++DOMWINDOW == 19 (0x7f4942b34800) [pid = 2428] [serial = 61] [outer = 0x7f493ecde400] [task 2018-12-16T11:27:24.222Z] 11:27:24 INFO - GECKO(2251) | [Child 2428, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8213 [task 2018-12-16T11:27:24.223Z] 11:27:24 INFO - GECKO(2251) | ++DOMWINDOW == 20 (0x7f494349cc00) [pid = 2428] [serial = 62] [outer = 0x7f493ecde400] [task 2018-12-16T11:27:24.224Z] 11:27:24 INFO - GECKO(2251) | [Child 2428, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8213 [task 2018-12-16T11:27:25.404Z] 11:27:25 INFO - GECKO(2251) | --DOMWINDOW == 13 (0x7f4fcdc0b800) [pid = 2251] [serial = 37] [outer = (nil)] [url = about:blank] [task 2018-12-16T11:27:25.404Z] 11:27:25 INFO - GECKO(2251) | --DOMWINDOW == 12 (0x7f4fcdc06800) [pid = 2251] [serial = 38] [outer = (nil)] [url = chrome://browser/content/aboutRobots.xhtml] [task 2018-12-16T11:27:26.046Z] 11:27:26 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_topsites_section.js | Should find a visible topsite context menu - {} == true -

Would the fix for bug 1471737 be valid here as well?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Honza Bambas (:mayhemer) from comment #18)

Would the fix for bug 1471737 be valid here as well?

I mean, not really exactly the same fix, but I guess it's possible that this code:

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/browser/components/newtab/test/browser/head.js#36-41

async function waitForPreloaded(browser) {
  let readyState = await ContentTask.spawn(browser, {}, () => content.document.readyState);
  if (readyState !== "complete") {
    await BrowserTestUtils.browserLoaded(browser);
  }
}

is being executed at a point where readyState == "complete" but the loaded document is actually about:blank instead of the new tab page, if that's what you mean?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to :Gijs (he/him) from comment #19)

if that's what you mean?

No, just wondering if the cause happens to be the same as for that bug and we could easily take it here as well or make it more general. If that's something else, then sorry for the churn.

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Component: Activity Streams: Newtab → New Tab Page

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Resolution: --- → INCOMPLETE
Severity: normal → S3

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.