1514600 - LSNG: Clear gUsages when temporary storage initialization fails

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P2)

Description

[Jan Varga [:janv]]

It can happen that temporary storage initialization fails for some reason. However, it can happen that the initialization is triggered again, but we already created gUsages for some origins, se we can end up with this assertion:
https://searchfox.org/mozilla-central/rev/1a4a7745fd4a14402a0de0e9abc040724d4fcf8f/dom/localstorage/ActorsParent.cpp#2589

Comment 1

[Jan Varga [:janv]]

Tom, you can take this, but note that it's not the same issue as in bug 1541771.
I'd like to review the patch once it's available.

Comment 2

[Tom Tung [:tt, :ttung]]

Sure, I will do this as soon as possible.

My impression for this is that either:

• Clear gUsages when temporary storage initialization fails
• Overwrite the correct usage for the second time, avoid misuse for the gUsages consumers by checking whether the storage is initialized yet

Comment 3

[Jan Varga [:janv]]

(In reply to Tom Tung [:tt, :ttung] from comment #2)

• Clear gUsages when temporary storage initialization fails

This should be enough.

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails;

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1514600 - P2 - Add an unit test to verify the fix in P1;

Depends on D27502

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/695621ee868d
P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/695621ee868d