Closed Bug 1514603 Opened 5 years ago Closed 5 years ago

Hovered menu in AB and composer not good visible with dark themes

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows 10
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6064+ fixed, thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird_esr60 64+ fixed
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

1514603-ab-composer-menu.patch
3.88 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
1514603-ab-composer-menu-beta-ESR.patch
3.88 KB, patch
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
On Windows 10 with a dark theme, the blue on hovered menus in AB and composer are not good visible. We should use the same styles we already have in main window.
Only hover over the entries in the menubar in AB- and composer window to see the effect.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9031756 - Flags: review?(jorgk)

        Attachment #9031757 -
        Flags: approval-comm-esr60?

        Attachment #9031757 -
        Flags: approval-comm-beta?

    
    

    
  
Comment on attachment 9031756 [details] [diff] [review]
1514603-ab-composer-menu.patch

Very nice, I can get this into TB 60.4 :-)

Just one question. Should the hover on the main window menu be a little lighter? Or maybe not.

        Attachment #9031756 -
        Flags: review?(jorgk) → review+

    
    

    
  
(In reply to Jorg K (GMT+1) from comment #3)
> 
> Just one question. Should the hover on the main window menu be a little
> lighter? Or maybe not.

It's tricky because, with drawInTitlebar, the same colour is used for normal LW-themes which also fill the titlebar with the menubar and for the Light/Dark themes which don't cover the menubar. And this can have every colour the user configures in Windows. I'm for leaving as it is.
Keywords: checkin-needed

        Attachment #9031757 -
        Flags: approval-comm-esr60?

        Attachment #9031757 -
        Flags: approval-comm-esr60+

        Attachment #9031757 -
        Flags: approval-comm-beta?

        Attachment #9031757 -
        Flags: approval-comm-beta+

    
    

    
  
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c550aac13814
Improve menubar visibility on Windows with a dark theme; r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: