Closed Bug 1514691 Opened 9 months ago Closed 6 months ago

Ask for confirmation when submitting empty translations

Categories

(Webtools :: Pontoon, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: codewithaniruddha, Mentored)

References

Details

Attachments

(3 files)

At least in .properties, there's no confirmation when someone tries to submit an empty translation. 

We should double check, and ask for confirmation that this is desired, especially when the original string is not empty. Right now we end up with a lot of issues in our localized files, e.g. Bug 1514546
I can't reproduce this, a confirmation box shows up when I try to submit an empty translation:
https://pontoon.mozilla.org/sl/firefox/browser/branding/official/brand.properties/?string=74118

However, Translate Toolkit checks need to be enabled for that. We should check if the users that submitted them have TTK checks disabled. If they do, we should solve the problem by enforing this particular check to everybody (AKA implement our own and disabled in in TTK).

Personal note, the relevant code is here:
https://github.com/mozilla/pontoon/blob/master/pontoon/checks/libraries/__init__.py#L74

Another thing we should do is make the message "Untranslated" more clear. Code:
https://github.com/mozilla/pontoon/blob/master/pontoon/checks/libraries/translate_toolkit.py#L61
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/fc06d27be93eb368715a5acdcd006072e0094561
Bug 1514691: Change wording of the empty translation warning (#1150)

Marking this as a mentored bug: "Create Pontoon check for empty translations and remove the 'untranslated' TTK check, which can be disabled by users."

Resources:
https://github.com/mozilla/pontoon/blob/master/pontoon/checks/libraries/__init__.py#L41
https://github.com/mozilla/pontoon/blob/master/pontoon/checks/libraries/pontoon.py

Mentor: m
Priority: -- → P3
Assignee: nobody → codewithaniruddha
Status: NEW → ASSIGNED
Depends on: 1521601
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.